diff options
author | Dylson Valente Neto <ama@n370.info> | 2018-10-12 11:15:37 -0700 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2018-10-14 08:10:22 -0700 |
commit | ede79c4cb8c9ad885a3eb6794683049057e23896 (patch) | |
tree | 9f8360c870e5d2b80fb7e44d605b85b45d7de710 | |
parent | f569ecf7b387df33e54683eb5bef690a16b045ac (diff) | |
download | android-node-v8-ede79c4cb8c9ad885a3eb6794683049057e23896.tar.gz android-node-v8-ede79c4cb8c9ad885a3eb6794683049057e23896.tar.bz2 android-node-v8-ede79c4cb8c9ad885a3eb6794683049057e23896.zip |
test: swap the order arguments are passed to assert
Documentation for assertions rule actual values should be passed first
followed by the expected value. This commit update the assertions the
changed file contains to comply to that rule. Changes also label the
assertions.
PR-URL: https://github.com/nodejs/node/pull/23580
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
-rw-r--r-- | test/pummel/test-keep-alive.js | 19 |
1 files changed, 16 insertions, 3 deletions
diff --git a/test/pummel/test-keep-alive.js b/test/pummel/test-keep-alive.js index 479ec12948..b62d731c7b 100644 --- a/test/pummel/test-keep-alive.js +++ b/test/pummel/test-keep-alive.js @@ -104,7 +104,20 @@ server.listen(common.PORT, () => { }); process.on('exit', function() { - assert.strictEqual(true, normalReqSec > 50); - assert.strictEqual(true, keepAliveReqSec > 50); - assert.strictEqual(true, normalReqSec < keepAliveReqSec); + assert.strictEqual( + normalReqSec > 50, + true, + `normalReqSec should be greater than 50, but got ${normalReqSec}` + ); + assert.strictEqual( + keepAliveReqSec > 50, + true, + `keepAliveReqSec should be greater than 50, but got ${keepAliveReqSec}` + ); + assert.strictEqual( + normalReqSec < keepAliveReqSec, + true, + 'normalReqSec should be less than keepAliveReqSec, ' + + `but ${normalReqSec} is greater than ${keepAliveReqSec}` + ); }); |