summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Bevenius <daniel.bevenius@gmail.com>2018-03-23 09:38:16 +0100
committerDaniel Bevenius <daniel.bevenius@gmail.com>2018-03-26 08:23:49 +0200
commitebbf3936001969905ce28dc588b2c71c3b65c146 (patch)
tree250f8e12609fe1ad23439d8666d69ba865462100
parent0d5720bf039007c96b7bad51cd7a22335a5b5c41 (diff)
downloadandroid-node-v8-ebbf3936001969905ce28dc588b2c71c3b65c146.tar.gz
android-node-v8-ebbf3936001969905ce28dc588b2c71c3b65c146.tar.bz2
android-node-v8-ebbf3936001969905ce28dc588b2c71c3b65c146.zip
src: name all builtin init functions Initialize
This commit renames a few of the builtin modules init functions to Initialize for consistency. PR-URL: https://github.com/nodejs/node/pull/19550 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
-rw-r--r--src/inspector_js_api.cc6
-rw-r--r--src/node.cc4
-rw-r--r--src/node_config.cc4
-rw-r--r--src/node_contextify.cc8
-rw-r--r--src/node_crypto.cc4
-rw-r--r--src/node_file.cc10
-rw-r--r--src/node_http_parser.cc10
-rw-r--r--src/node_i18n.cc10
-rw-r--r--src/node_perf.cc8
-rw-r--r--src/node_serdes.cc8
-rw-r--r--src/node_trace_events.cc10
-rw-r--r--src/node_url.cc10
-rw-r--r--src/node_v8.cc8
-rw-r--r--src/node_zlib.cc10
-rw-r--r--src/uv.cc8
15 files changed, 59 insertions, 59 deletions
diff --git a/src/inspector_js_api.cc b/src/inspector_js_api.cc
index 3d806d71ef..9a380bb2df 100644
--- a/src/inspector_js_api.cc
+++ b/src/inspector_js_api.cc
@@ -296,8 +296,8 @@ void Url(const FunctionCallbackInfo<Value>& args) {
args.GetReturnValue().Set(OneByteString(env->isolate(), url.c_str()));
}
-void InitInspectorBindings(Local<Object> target, Local<Value> unused,
- Local<Context> context, void* priv) {
+void Initialize(Local<Object> target, Local<Value> unused,
+ Local<Context> context, void* priv) {
Environment* env = Environment::GetCurrent(context);
{
auto obj = Object::New(env->isolate());
@@ -341,4 +341,4 @@ void InitInspectorBindings(Local<Object> target, Local<Value> unused,
} // namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(inspector,
- node::inspector::InitInspectorBindings);
+ node::inspector::Initialize);
diff --git a/src/node.cc b/src/node.cc
index 8dfefcae6e..c0ae99f423 100644
--- a/src/node.cc
+++ b/src/node.cc
@@ -4647,7 +4647,7 @@ void RegisterBuiltinModules() {
} // namespace node
#if !HAVE_INSPECTOR
-void InitEmptyBindings() {}
+void Initialize() {}
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(inspector, InitEmptyBindings)
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(inspector, Initialize)
#endif // !HAVE_INSPECTOR
diff --git a/src/node_config.cc b/src/node_config.cc
index cac551ad2c..0542bff1d6 100644
--- a/src/node_config.cc
+++ b/src/node_config.cc
@@ -36,7 +36,7 @@ using v8::Value;
value, ReadOnly).FromJust(); \
} while (0)
-static void InitConfig(Local<Object> target,
+static void Initialize(Local<Object> target,
Local<Value> unused,
Local<Context> context) {
Environment* env = Environment::GetCurrent(context);
@@ -138,4 +138,4 @@ static void InitConfig(Local<Object> target,
} // namespace node
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(config, node::InitConfig)
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(config, node::Initialize)
diff --git a/src/node_contextify.cc b/src/node_contextify.cc
index 07aa656b2c..42f66885bb 100644
--- a/src/node_contextify.cc
+++ b/src/node_contextify.cc
@@ -1143,9 +1143,9 @@ class ContextifyScript : public BaseObject {
};
-void InitContextify(Local<Object> target,
- Local<Value> unused,
- Local<Context> context) {
+void Initialize(Local<Object> target,
+ Local<Value> unused,
+ Local<Context> context) {
Environment* env = Environment::GetCurrent(context);
ContextifyContext::Init(env, target);
ContextifyScript::Init(env, target);
@@ -1154,4 +1154,4 @@ void InitContextify(Local<Object> target,
} // namespace contextify
} // namespace node
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(contextify, node::contextify::InitContextify)
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(contextify, node::contextify::Initialize)
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
index 3253b701f3..2384f6997c 100644
--- a/src/node_crypto.cc
+++ b/src/node_crypto.cc
@@ -5778,7 +5778,7 @@ void SetFipsCrypto(const FunctionCallbackInfo<Value>& args) {
}
#endif /* NODE_FIPS_MODE */
-void InitCrypto(Local<Object> target,
+void Initialize(Local<Object> target,
Local<Value> unused,
Local<Context> context,
void* priv) {
@@ -5852,4 +5852,4 @@ void InitCrypto(Local<Object> target,
} // namespace crypto
} // namespace node
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(crypto, node::crypto::InitCrypto)
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(crypto, node::crypto::Initialize)
diff --git a/src/node_file.cc b/src/node_file.cc
index 7b493de131..533ed6c19c 100644
--- a/src/node_file.cc
+++ b/src/node_file.cc
@@ -1857,10 +1857,10 @@ static void Mkdtemp(const FunctionCallbackInfo<Value>& args) {
}
}
-void InitFs(Local<Object> target,
- Local<Value> unused,
- Local<Context> context,
- void* priv) {
+void Initialize(Local<Object> target,
+ Local<Value> unused,
+ Local<Context> context,
+ void* priv) {
Environment* env = Environment::GetCurrent(context);
env->SetMethod(target, "access", Access);
@@ -1976,4 +1976,4 @@ void InitFs(Local<Object> target,
} // end namespace node
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(fs, node::fs::InitFs)
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(fs, node::fs::Initialize)
diff --git a/src/node_http_parser.cc b/src/node_http_parser.cc
index 8ab13e0734..7fddb747cd 100644
--- a/src/node_http_parser.cc
+++ b/src/node_http_parser.cc
@@ -728,10 +728,10 @@ const struct http_parser_settings Parser::settings = {
};
-void InitHttpParser(Local<Object> target,
- Local<Value> unused,
- Local<Context> context,
- void* priv) {
+void Initialize(Local<Object> target,
+ Local<Value> unused,
+ Local<Context> context,
+ void* priv) {
Environment* env = Environment::GetCurrent(context);
Local<FunctionTemplate> t = env->NewFunctionTemplate(Parser::New);
t->InstanceTemplate()->SetInternalFieldCount(1);
@@ -778,4 +778,4 @@ void InitHttpParser(Local<Object> target,
} // anonymous namespace
} // namespace node
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(http_parser, node::InitHttpParser)
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(http_parser, node::Initialize)
diff --git a/src/node_i18n.cc b/src/node_i18n.cc
index d65fc55ed1..7f462d5aea 100644
--- a/src/node_i18n.cc
+++ b/src/node_i18n.cc
@@ -852,10 +852,10 @@ static void GetStringWidth(const FunctionCallbackInfo<Value>& args) {
args.GetReturnValue().Set(width);
}
-void Init(Local<Object> target,
- Local<Value> unused,
- Local<Context> context,
- void* priv) {
+void Initialize(Local<Object> target,
+ Local<Value> unused,
+ Local<Context> context,
+ void* priv) {
Environment* env = Environment::GetCurrent(context);
env->SetMethod(target, "toUnicode", ToUnicode);
env->SetMethod(target, "toASCII", ToASCII);
@@ -875,6 +875,6 @@ void Init(Local<Object> target,
} // namespace i18n
} // namespace node
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(icu, node::i18n::Init)
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(icu, node::i18n::Initialize)
#endif // NODE_HAVE_I18N_SUPPORT
diff --git a/src/node_perf.cc b/src/node_perf.cc
index 60ab530420..ac17e5b873 100644
--- a/src/node_perf.cc
+++ b/src/node_perf.cc
@@ -372,9 +372,9 @@ void Timerify(const FunctionCallbackInfo<Value>& args) {
}
-void Init(Local<Object> target,
- Local<Value> unused,
- Local<Context> context) {
+void Initialize(Local<Object> target,
+ Local<Value> unused,
+ Local<Context> context) {
Environment* env = Environment::GetCurrent(context);
Isolate* isolate = env->isolate();
performance_state* state = env->performance_state();
@@ -443,4 +443,4 @@ void Init(Local<Object> target,
} // namespace performance
} // namespace node
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(performance, node::performance::Init)
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(performance, node::performance::Initialize)
diff --git a/src/node_serdes.cc b/src/node_serdes.cc
index 5eb4455a0e..1995eb1b9b 100644
--- a/src/node_serdes.cc
+++ b/src/node_serdes.cc
@@ -424,9 +424,9 @@ void DeserializerContext::ReadRawBytes(
args.GetReturnValue().Set(offset);
}
-void InitializeSerdesBindings(Local<Object> target,
- Local<Value> unused,
- Local<Context> context) {
+void Initialize(Local<Object> target,
+ Local<Value> unused,
+ Local<Context> context) {
Environment* env = Environment::GetCurrent(context);
Local<FunctionTemplate> ser =
env->NewFunctionTemplate(SerializerContext::New);
@@ -483,4 +483,4 @@ void InitializeSerdesBindings(Local<Object> target,
} // anonymous namespace
} // namespace node
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(serdes, node::InitializeSerdesBindings)
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(serdes, node::Initialize)
diff --git a/src/node_trace_events.cc b/src/node_trace_events.cc
index f269b32fbe..96d00115fe 100644
--- a/src/node_trace_events.cc
+++ b/src/node_trace_events.cc
@@ -132,10 +132,10 @@ static void CategoryGroupEnabled(const FunctionCallbackInfo<Value>& args) {
args.GetReturnValue().Set(*category_group_enabled > 0);
}
-void InitializeTraceEvents(Local<Object> target,
- Local<Value> unused,
- Local<Context> context,
- void* priv) {
+void Initialize(Local<Object> target,
+ Local<Value> unused,
+ Local<Context> context,
+ void* priv) {
Environment* env = Environment::GetCurrent(context);
env->SetMethod(target, "emit", Emit);
@@ -144,4 +144,4 @@ void InitializeTraceEvents(Local<Object> target,
} // namespace node
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(trace_events, node::InitializeTraceEvents)
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(trace_events, node::Initialize)
diff --git a/src/node_url.cc b/src/node_url.cc
index 6b56628d75..901fa0761a 100644
--- a/src/node_url.cc
+++ b/src/node_url.cc
@@ -2290,10 +2290,10 @@ static void SetURLConstructor(const FunctionCallbackInfo<Value>& args) {
env->set_url_constructor_function(args[0].As<Function>());
}
-static void Init(Local<Object> target,
- Local<Value> unused,
- Local<Context> context,
- void* priv) {
+static void Initialize(Local<Object> target,
+ Local<Value> unused,
+ Local<Context> context,
+ void* priv) {
Environment* env = Environment::GetCurrent(context);
env->SetMethod(target, "parse", Parse);
env->SetMethod(target, "encodeAuth", EncodeAuthSet);
@@ -2313,4 +2313,4 @@ static void Init(Local<Object> target,
} // namespace url
} // namespace node
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(url, node::url::Init)
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(url, node::url::Initialize)
diff --git a/src/node_v8.cc b/src/node_v8.cc
index d1514cb097..bb41b569e6 100644
--- a/src/node_v8.cc
+++ b/src/node_v8.cc
@@ -119,9 +119,9 @@ void SetFlagsFromString(const FunctionCallbackInfo<Value>& args) {
}
-void InitializeV8Bindings(Local<Object> target,
- Local<Value> unused,
- Local<Context> context) {
+void Initialize(Local<Object> target,
+ Local<Value> unused,
+ Local<Context> context) {
Environment* env = Environment::GetCurrent(context);
env->SetMethod(target, "cachedDataVersionTag", CachedDataVersionTag);
@@ -201,4 +201,4 @@ void InitializeV8Bindings(Local<Object> target,
} // namespace node
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(v8, node::InitializeV8Bindings)
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(v8, node::Initialize)
diff --git a/src/node_zlib.cc b/src/node_zlib.cc
index 388630d507..500a62a52b 100644
--- a/src/node_zlib.cc
+++ b/src/node_zlib.cc
@@ -681,10 +681,10 @@ class ZCtx : public AsyncWrap {
};
-void InitZlib(Local<Object> target,
- Local<Value> unused,
- Local<Context> context,
- void* priv) {
+void Initialize(Local<Object> target,
+ Local<Value> unused,
+ Local<Context> context,
+ void* priv) {
Environment* env = Environment::GetCurrent(context);
Local<FunctionTemplate> z = env->NewFunctionTemplate(ZCtx::New);
@@ -709,4 +709,4 @@ void InitZlib(Local<Object> target,
} // anonymous namespace
} // namespace node
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(zlib, node::InitZlib)
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(zlib, node::Initialize)
diff --git a/src/uv.cc b/src/uv.cc
index 1ffd093c6b..85cb2ad537 100644
--- a/src/uv.cc
+++ b/src/uv.cc
@@ -50,9 +50,9 @@ void ErrName(const FunctionCallbackInfo<Value>& args) {
}
-void InitializeUV(Local<Object> target,
- Local<Value> unused,
- Local<Context> context) {
+void Initialize(Local<Object> target,
+ Local<Value> unused,
+ Local<Context> context) {
Environment* env = Environment::GetCurrent(context);
Isolate* isolate = env->isolate();
target->Set(FIXED_ONE_BYTE_STRING(isolate, "errname"),
@@ -82,4 +82,4 @@ void InitializeUV(Local<Object> target,
} // anonymous namespace
} // namespace node
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(uv, node::InitializeUV)
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(uv, node::Initialize)