tools: non-Ascii linter for /lib only

Non-ASCII characters in /lib get compiled into the node binary,
and may bloat the binary size unnecessarily. A linter rule may
help prevent this.

PR-URL: https://github.com/nodejs/node/pull/18043
Fixes: https://github.com/nodejs/node/issues/11209
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>

8 files changed, 71 insertions, 5 deletions

diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
index 437aa57564..0b00638e2a 100644
--- a/lib/.eslintrc.yaml
+++ b/lib/.eslintrc.yaml
@@ -6,3 +6,4 @@ rules:
   buffer-constructor: error
   no-let-in-for-declaration: error
   lowercase-name-for-primitive: error
+  non-ascii-character: error
diff --git a/lib/console.js b/lib/console.js
index b6fb3d88b1..e216934a7f 100644
--- a/lib/console.js
+++ b/lib/console.js
@@ -84,7 +84,7 @@ function createWriteErrorHandler(stream) {
       // If there was an error, it will be emitted on `stream` as
       // an `error` event. Adding a `once` listener will keep that error
       // from becoming an uncaught exception, but since the handler is
-      // removed after the event, non-console.* writes won’t be affected.
+      // removed after the event, non-console.* writes won't be affected.
       // we are only adding noop if there is no one else listening for 'error'
       if (stream.listenerCount('error') === 0) {
         stream.on('error', noop);
@@ -125,7 +125,7 @@ function write(ignoreErrors, stream, string, errorhandler, groupIndent) {
     // even in edge cases such as low stack space.
     if (e.message === MAX_STACK_MESSAGE && e.name === 'RangeError')
       throw e;
-    // Sorry, there’s no proper way to pass along the error here.
+    // Sorry, there's no proper way to pass along the error here.
   } finally {
     stream.removeListener('error', noop);
   }
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
index 595030a13a..7702d998fa 100644
--- a/lib/internal/http2/core.js
+++ b/lib/internal/http2/core.js
@@ -1884,7 +1884,7 @@ function processRespondWithFD(self, fd, headers, offset = 0, length = -1,
     return;
   }
   // exact length of the file doesn't matter here, since the
-  // stream is closing anyway — just use 1 to signify that
+  // stream is closing anyway - just use 1 to signify that
   // a write does exist
   trackWriteState(self, 1);
 }
diff --git a/lib/internal/test/unicode.js b/lib/internal/test/unicode.js
index 1445276d9a..7172a43ec2 100644
--- a/lib/internal/test/unicode.js
+++ b/lib/internal/test/unicode.js
@@ -3,4 +3,6 @@
 // This module exists entirely for regression testing purposes.
 // See `test/parallel/test-internal-unicode.js`.
 
+/* eslint-disable non-ascii-character */
 module.exports = '✓';
+/* eslint-enable non-ascii-character */
diff --git a/lib/stream.js b/lib/stream.js
index edc5f231b8..9a816600a0 100644
--- a/lib/stream.js
+++ b/lib/stream.js
@@ -45,7 +45,7 @@ try {
   try {
     Stream._isUint8Array = process.binding('util').isUint8Array;
   } catch (e) {
-    // This throws for Node < 4.2.0 because there’s no util binding and
+    // This throws for Node < 4.2.0 because there's no util binding and
     // returns undefined for Node < 7.4.0.
   }
 }
diff --git a/lib/timers.js b/lib/timers.js
index 99ed920e9a..8d061ab014 100644
--- a/lib/timers.js
+++ b/lib/timers.js
@@ -97,6 +97,7 @@ const Timeout = timerInternals.Timeout;
 // TimerWrap C++ handle, which makes the call after the duration to process the
 // list it is attached to.
 //
+/* eslint-disable non-ascii-character */
 //
 // ╔════ > Object Map
 // ║
@@ -118,6 +119,7 @@ const Timeout = timerInternals.Timeout;
 // ║
 // ╚════ > Linked List
 //
+/* eslint-enable non-ascii-character */
 //
 // With this, virtually constant-time insertion (append), removal, and timeout
 // is possible in the JavaScript layer. Any one list of timers is able to be
diff --git a/lib/zlib.js b/lib/zlib.js
index 8446f3a03a..6262ddb6bc 100644
--- a/lib/zlib.js
+++ b/lib/zlib.js
@@ -374,7 +374,7 @@ Zlib.prototype.flush = function flush(kind, callback) {
     this._scheduledFlushFlag = maxFlush(kind, this._scheduledFlushFlag);
 
     // If a callback was passed, always register a new `drain` + flush handler,
-    // mostly because that’s simpler and flush callbacks piling up is a rare
+    // mostly because that's simpler and flush callbacks piling up is a rare
     // thing anyway.
     if (!alreadyHadFlushScheduled || callback) {
       const drainHandler = () => this.flush(this._scheduledFlushFlag, callback);
diff --git a/tools/eslint-rules/non-ascii-character.js b/tools/eslint-rules/non-ascii-character.js
new file mode 100644
index 0000000000..e67aac7cd9
--- /dev/null
+++ b/tools/eslint-rules/non-ascii-character.js
@@ -0,0 +1,61 @@
+/**
+ * @fileOverview Any non-ASCII characters in lib/ will increase the size
+ *               of the compiled node binary. This linter rule ensures that
+ *               any such character is reported.
+ * @author Sarat Addepalli <sarat.addepalli@gmail.com>
+ */
+
+'use strict';
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+const nonAsciiRegexPattern = /[^\r\n\x20-\x7e]/;
+const suggestions = {
+  '’': '\'',
+  '‛': '\'',
+  '‘': '\'',
+  '“': '"',
+  '‟': '"',
+  '”': '"',
+  '«': '"',
+  '»': '"',
+  '—': '-'
+};
+
+module.exports = (context) => {
+
+  const reportIfError = (node, sourceCode) => {
+
+    const matches = sourceCode.text.match(nonAsciiRegexPattern);
+
+    if (!matches) return;
+
+    const offendingCharacter = matches[0];
+    const offendingCharacterPosition = matches.index;
+    const suggestion = suggestions[offendingCharacter];
+
+    let message = `Non-ASCII character '${offendingCharacter}' detected.`;
+
+    message = suggestion ?
+      `${message} Consider replacing with: ${suggestion}` :
+      message;
+
+    context.report({
+      node,
+      message,
+      loc: sourceCode.getLocFromIndex(offendingCharacterPosition),
+      fix: (fixer) => {
+        return fixer.replaceText(
+          node,
+          suggestion ? `${suggestion}` : ''
+        );
+      }
+    });
+  };
+
+  return {
+    Program: (node) => reportIfError(node, context.getSourceCode())
+  };
+};