diff options
| author | Sam Roberts <vieuxtech@gmail.com> | 2019-05-02 09:03:53 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-05-04 21:24:17 -0700 |
| commit | c21693b39dfc428bc8a25a6bd7e47be7e34fdb21 (patch) | |
| tree | 5dc011710189da254be9ad41be1c90e83aed51e1 | |
| parent | 11e1e0050b548c2b815d40dfa0cfbaf63289ae62 (diff) | |
| download | android-node-v8-c21693b39dfc428bc8a25a6bd7e47be7e34fdb21.tar.gz android-node-v8-c21693b39dfc428bc8a25a6bd7e47be7e34fdb21.tar.bz2 android-node-v8-c21693b39dfc428bc8a25a6bd7e47be7e34fdb21.zip | |
src: remove node_options-inl.h from header files
Fix unnecessary inclusion of node_options-inl.h into env.h via
inspector_agent.h, causing almost all of src/ to recompile on any change
to the options parser. Its intended that *-inl.h header files are only
included into the src files that call the inline methods.
PR-URL: https://github.com/nodejs/node/pull/27538
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
| -rw-r--r-- | src/inspector_agent.cc | 1 | ||||
| -rw-r--r-- | src/inspector_agent.h | 2 | ||||
| -rw-r--r-- | src/node_worker.cc | 1 |
3 files changed, 3 insertions, 1 deletions
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc index 78af5508d0..fce174012f 100644 --- a/src/inspector_agent.cc +++ b/src/inspector_agent.cc @@ -9,6 +9,7 @@ #include "node/inspector/protocol/Protocol.h" #include "node_errors.h" #include "node_internals.h" +#include "node_options-inl.h" #include "node_process.h" #include "node_url.h" #include "v8-inspector.h" diff --git a/src/inspector_agent.h b/src/inspector_agent.h index c7c92186d1..1c2bde0da7 100644 --- a/src/inspector_agent.h +++ b/src/inspector_agent.h @@ -6,7 +6,7 @@ #error("This header can only be used when inspector is enabled") #endif -#include "node_options-inl.h" +#include "node_options.h" #include "v8.h" #include <cstddef> diff --git a/src/node_worker.cc b/src/node_worker.cc index c1a1123ef1..f9b675e96a 100644 --- a/src/node_worker.cc +++ b/src/node_worker.cc @@ -2,6 +2,7 @@ #include "debug_utils.h" #include "node_errors.h" #include "node_buffer.h" +#include "node_options-inl.h" #include "node_perf.h" #include "util.h" #include "async_wrap-inl.h" |