summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2019-04-06 22:28:25 +0200
committerDaniel Bevenius <daniel.bevenius@gmail.com>2019-04-10 05:43:47 +0200
commitc1e03eda07758a08e9469f5aa94038902bf9aacb (patch)
tree1f45e5d6369dcd5efb76eb10449a3bf27a0d1fdc
parentf1ab837b0c312ccd81ec5114ca0cee69acf76060 (diff)
downloadandroid-node-v8-c1e03eda07758a08e9469f5aa94038902bf9aacb.tar.gz
android-node-v8-c1e03eda07758a08e9469f5aa94038902bf9aacb.tar.bz2
android-node-v8-c1e03eda07758a08e9469f5aa94038902bf9aacb.zip
src: use SealHandleScope for inspector tasks
This addresses a TODO comment that can be resolved, now that we have V8 7.4. PR-URL: https://github.com/nodejs/node/pull/27116 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
-rw-r--r--src/inspector/main_thread_interface.cc8
1 files changed, 1 insertions, 7 deletions
diff --git a/src/inspector/main_thread_interface.cc b/src/inspector/main_thread_interface.cc
index 5b339a39ae..ac4461baed 100644
--- a/src/inspector/main_thread_interface.cc
+++ b/src/inspector/main_thread_interface.cc
@@ -269,13 +269,7 @@ void MainThreadInterface::DispatchMessages() {
std::swap(dispatching_message_queue_.front(), task);
dispatching_message_queue_.pop_front();
- // TODO(addaleax): The V8 inspector code currently sometimes allocates
- // handles that leak to the outside scope, rendering a HandleScope here
- // necessary. This handle scope can be removed/turned into a
- // SealHandleScope once/if
- // https://chromium-review.googlesource.com/c/v8/v8/+/1484304 makes it
- // into our copy of V8, maybe guarded with #ifdef DEBUG if we want.
- v8::HandleScope handle_scope(isolate_);
+ v8::SealHandleScope seal_handle_scope(isolate_);
task->Call(this);
}
} while (had_messages);