diff options
author | Jon Moss <me@jonathanmoss.me> | 2018-07-30 16:11:46 -0400 |
---|---|---|
committer | Jon Moss <me@jonathanmoss.me> | 2018-08-04 15:32:35 -0400 |
commit | bd2ee60eae26973244e094c1f28d737afd392e94 (patch) | |
tree | 17f80fc6a03d90ea094bc70f6a33768becec3143 | |
parent | 34fb560c924f365b2d09b70376768634c527e3ae (diff) | |
download | android-node-v8-bd2ee60eae26973244e094c1f28d737afd392e94.tar.gz android-node-v8-bd2ee60eae26973244e094c1f28d737afd392e94.tar.bz2 android-node-v8-bd2ee60eae26973244e094c1f28d737afd392e94.zip |
src: remove unused env->vm_parsing_context_symbol
Stopped being used via 77b52fd58f7398a81999c81afd21fe2e156c0766, was
originally added in d932e802317f9f61bd10988189fa43ed03ad0f61.
For the one remaining usecase inside of `lib/vm.js`, define a Symbol at
the top of the file.
PR-URL: https://github.com/nodejs/node/pull/22034
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
-rw-r--r-- | lib/vm.js | 3 | ||||
-rw-r--r-- | src/env.h | 1 | ||||
-rw-r--r-- | src/node_contextify.cc | 10 |
3 files changed, 1 insertions, 13 deletions
@@ -23,14 +23,13 @@ const { ContextifyScript, - kParsingContext, makeContext, isContext: _isContext, } = process.binding('contextify'); - const { ERR_INVALID_ARG_TYPE } = require('internal/errors').codes; const { isUint8Array } = require('internal/util/types'); const { validateInt32, validateUint32 } = require('internal/validators'); +const kParsingContext = Symbol('script parsing context'); class Script extends ContextifyScript { constructor(code, options = {}) { @@ -359,7 +359,6 @@ struct PackageConfig { V(tls_wrap_constructor_function, v8::Function) \ V(tty_constructor_template, v8::FunctionTemplate) \ V(udp_constructor_function, v8::Function) \ - V(vm_parsing_context_symbol, v8::Symbol) \ V(url_constructor_function, v8::Function) \ V(write_wrap_template, v8::ObjectTemplate) diff --git a/src/node_contextify.cc b/src/node_contextify.cc index 74b7c594d5..be4c0e5cf3 100644 --- a/src/node_contextify.cc +++ b/src/node_contextify.cc @@ -609,16 +609,6 @@ class ContextifyScript : public BaseObject { target->Set(class_name, script_tmpl->GetFunction()); env->set_script_context_constructor_template(script_tmpl); - - Local<Symbol> parsing_context_symbol = - Symbol::New(env->isolate(), - FIXED_ONE_BYTE_STRING(env->isolate(), - "script parsing context")); - env->set_vm_parsing_context_symbol(parsing_context_symbol); - target->Set(env->context(), - FIXED_ONE_BYTE_STRING(env->isolate(), "kParsingContext"), - parsing_context_symbol) - .FromJust(); } |