diff options
author | Mathieu Darse <mattdarse@gmail.com> | 2015-03-21 14:37:47 +0100 |
---|---|---|
committer | Rod Vagg <rod@vagg.org> | 2015-03-22 17:32:28 +1100 |
commit | bc9c1a5a7b822f8d1e9208eff8cfaadcdbd52673 (patch) | |
tree | 8bdabc2eacd4363cc54a0bb81898995c13e11117 | |
parent | 9ae1a612149c27d4ffc6e8e6561d4845ad786674 (diff) | |
download | android-node-v8-bc9c1a5a7b822f8d1e9208eff8cfaadcdbd52673.tar.gz android-node-v8-bc9c1a5a7b822f8d1e9208eff8cfaadcdbd52673.tar.bz2 android-node-v8-bc9c1a5a7b822f8d1e9208eff8cfaadcdbd52673.zip |
doc: fix typo in CHANGELOG
PR-URL: https://github.com/iojs/io.js/pull/1230
Reviewed-By: Rod Vagg <rod@vagg.org>
-rw-r--r-- | CHANGELOG.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index c3f3f304aa..3c12553372 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1078,9 +1078,9 @@ In general it is recommended that you use [NAN](https://github.com/rvagg/nan) as - Exposed method signature has changed from `Handle<Value> Method(const Arguments& args)` to `void Method(const v8::FunctionCallbackInfo<Value>& args)` with the newly introduced `FunctionCallbackInfo` also taking the return value via `args.GetReturnValue().Set(value)` instead of `scope.Close(value)`, `Arguments` has been removed. - Exposed setter signature has changed from `void Setter(Local<String> property, Local<Value> value, const v8::AccessorInfo& args)` `void Setter(Local<String> property, Local<Value> value, const v8::PropertyCallbackInfo<void>& args)`. -- Exposed getter signature has changed from `void Getter(Local<String> property, Local<Value> value, const v8::AccessorInfo& args)` `void Setter(Local<String> property, Local<Value> value, const v8::PropertyCallbackInfo<Value>& args)`. +- Exposed getter signature has changed from `void Getter(Local<String> property, Local<Value> value, const v8::AccessorInfo& args)` `void Getter(Local<String> property, Local<Value> value, const v8::PropertyCallbackInfo<Value>& args)`. - Exposed property setter signature has changed from `Handle<Value> Setter(Local<String> property, Local<Value> value, const v8::AccessorInfo& args)` `void Setter(Local<String> property, Local<Value> value, const v8::PropertyCallbackInfo<Value>& args)`. -- Exposed property getter signature has changed from `Handle<Value> Getter(Local<String> property, Local<Value> value, const v8::AccessorInfo& args)` `void Setter(Local<String> property, Local<Value> value, const v8::PropertyCallbackInfo<Value>& args)`. +- Exposed property getter signature has changed from `Handle<Value> Getter(Local<String> property, Local<Value> value, const v8::AccessorInfo& args)` `void Getter(Local<String> property, Local<Value> value, const v8::PropertyCallbackInfo<Value>& args)`. - Similar changes have been made to property enumerators, property deleters, property query, index getter, index setter, index enumerator, index deleter, index query. - V8 objects instantiated in C++ now require an `Isolate*` argument as the first argument. In most cases it is OK to simply pass `v8::Isolate::GetCurrent()`, e.g. `Date::New(Isolate::GetCurrent(), time)`, or `String::NewFromUtf8(Isolate::GetCurrent(), "foobar")`. - `HandleScope scope` now requires an `Isolate*` argument, i.e. `HandleScope scope(isolate)`, in most cases `v8::Isolate::GetCurrent()` is OK. |