summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2017-11-29 23:40:18 +0100
committerAnna Henningsen <anna@addaleax.net>2017-12-05 23:49:36 +0100
commitaeddc3676bc9afe940106d34f30523f27b4cb44f (patch)
treea1258c5e70047b29de3b6f00b2f7486ccde39eeb
parent92011e417cedea93907987445058b4d7e30e4325 (diff)
downloadandroid-node-v8-aeddc3676bc9afe940106d34f30523f27b4cb44f.tar.gz
android-node-v8-aeddc3676bc9afe940106d34f30523f27b4cb44f.tar.bz2
android-node-v8-aeddc3676bc9afe940106d34f30523f27b4cb44f.zip
src: remove tracking for exception arrow data
This is unnecessary since we only run `AppendExceptionLine()` once per exception at this point anyway. PR-URL: https://github.com/nodejs/node/pull/17394 Reviewed-By: James M Snell <jasnell@gmail.com>
-rw-r--r--src/env.h1
-rw-r--r--src/node.cc10
-rw-r--r--src/node_contextify.cc4
3 files changed, 1 insertions, 14 deletions
diff --git a/src/env.h b/src/env.h
index ed7b7afc93..a853726ef0 100644
--- a/src/env.h
+++ b/src/env.h
@@ -91,7 +91,6 @@ class ModuleWrap;
V(contextify_global_private_symbol, "node:contextify:global") \
V(decorated_private_symbol, "node:decorated") \
V(npn_buffer_private_symbol, "node:npnBuffer") \
- V(processed_private_symbol, "node:processed") \
V(selected_npn_buffer_private_symbol, "node:selectedNpnBuffer") \
V(domain_private_symbol, "node:domain") \
diff --git a/src/node.cc b/src/node.cc
index 887c59aa1a..03220b664f 100644
--- a/src/node.cc
+++ b/src/node.cc
@@ -1301,16 +1301,6 @@ void AppendExceptionLine(Environment* env,
Local<Object> err_obj;
if (!er.IsEmpty() && er->IsObject()) {
err_obj = er.As<Object>();
-
- auto context = env->context();
- auto processed_private_symbol = env->processed_private_symbol();
- // Do it only once per message
- if (err_obj->HasPrivate(context, processed_private_symbol).FromJust())
- return;
- err_obj->SetPrivate(
- context,
- processed_private_symbol,
- True(env->isolate()));
}
// Print (filename):(line number): (message).
diff --git a/src/node_contextify.cc b/src/node_contextify.cc
index 73c5fe08ab..5b389f2ff8 100644
--- a/src/node_contextify.cc
+++ b/src/node_contextify.cc
@@ -668,9 +668,7 @@ class ContextifyScript : public BaseObject {
compile_options);
if (v8_script.IsEmpty()) {
- if (display_errors) {
- DecorateErrorStack(env, try_catch);
- }
+ DecorateErrorStack(env, try_catch);
try_catch.ReThrow();
return;
}