diff options
| author | cjihrig <cjihrig@gmail.com> | 2018-05-12 23:07:52 -0400 |
|---|---|---|
| committer | cjihrig <cjihrig@gmail.com> | 2018-05-14 13:30:56 -0400 |
| commit | a9c34b4a80cf942a082379e3f1f3071238018076 (patch) | |
| tree | 6520de494c346d7e02a1ca0f5e652ba58400a019 | |
| parent | faa2daed6c2430336267a1bad675abf2585edd84 (diff) | |
| download | android-node-v8-a9c34b4a80cf942a082379e3f1f3071238018076.tar.gz android-node-v8-a9c34b4a80cf942a082379e3f1f3071238018076.tar.bz2 android-node-v8-a9c34b4a80cf942a082379e3f1f3071238018076.zip | |
stream: simplify writable's validChunk()
This commit simplifies validChunk() by removing an unnecessary
intermediate variable.
PR-URL: https://github.com/nodejs/node/pull/20696
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
| -rw-r--r-- | lib/_stream_writable.js | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/lib/_stream_writable.js b/lib/_stream_writable.js index 3df14206f1..2f69ba931a 100644 --- a/lib/_stream_writable.js +++ b/lib/_stream_writable.js @@ -250,7 +250,6 @@ function writeAfterEnd(stream, cb) { // mode the stream is in. Currently this means that `null` is never accepted // and undefined/non-string values are only allowed in object mode. function validChunk(stream, state, chunk, cb) { - var valid = true; var er; if (chunk === null) { @@ -261,9 +260,9 @@ function validChunk(stream, state, chunk, cb) { if (er) { stream.emit('error', er); process.nextTick(cb, er); - valid = false; + return false; } - return valid; + return true; } Writable.prototype.write = function(chunk, encoding, cb) { |