diff options
author | Jenna Vuong <hello@jennavuong.com> | 2016-10-09 22:28:42 -0700 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2016-10-13 15:10:54 -0700 |
commit | a7970c0a25226907c6a89266f24b06080547d90b (patch) | |
tree | 60c9f15e8aedf9360159934014f433b32d238ee7 | |
parent | 804d57db676d54e237a19d42bf443db2b9796525 (diff) | |
download | android-node-v8-a7970c0a25226907c6a89266f24b06080547d90b.tar.gz android-node-v8-a7970c0a25226907c6a89266f24b06080547d90b.tar.bz2 android-node-v8-a7970c0a25226907c6a89266f24b06080547d90b.zip |
test: refactor test-file-*
* var to const
* add check that expected error is ENOENT
* indexOf() to includes()
PR-URL: https://github.com/nodejs/node/pull/8999
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-rw-r--r-- | test/parallel/test-file-read-noexist.js | 11 | ||||
-rw-r--r-- | test/parallel/test-file-write-stream2.js | 14 |
2 files changed, 13 insertions, 12 deletions
diff --git a/test/parallel/test-file-read-noexist.js b/test/parallel/test-file-read-noexist.js index 166beea0f8..423c62dfd5 100644 --- a/test/parallel/test-file-read-noexist.js +++ b/test/parallel/test-file-read-noexist.js @@ -1,10 +1,11 @@ 'use strict'; -var common = require('../common'); -var assert = require('assert'); -var path = require('path'); -var fs = require('fs'); +const common = require('../common'); +const assert = require('assert'); +const path = require('path'); +const fs = require('fs'); -var filename = path.join(common.fixturesDir, 'does_not_exist.txt'); +const filename = path.join(common.fixturesDir, 'does_not_exist.txt'); fs.readFile(filename, 'latin1', common.mustCall(function(err, content) { assert.ok(err); + assert.strictEqual(err.code, 'ENOENT'); })); diff --git a/test/parallel/test-file-write-stream2.js b/test/parallel/test-file-write-stream2.js index 69fdb7051f..77e8119d25 100644 --- a/test/parallel/test-file-write-stream2.js +++ b/test/parallel/test-file-write-stream2.js @@ -1,12 +1,12 @@ 'use strict'; -var common = require('../common'); -var assert = require('assert'); +const common = require('../common'); +const assert = require('assert'); -var path = require('path'); -var fs = require('fs'); +const path = require('path'); +const fs = require('fs'); -var filepath = path.join(common.tmpDir, 'write.txt'); +const filepath = path.join(common.tmpDir, 'write.txt'); var file; const EXPECTED = '012345678910'; @@ -76,12 +76,12 @@ file.on('close', function() { file.on('error', function(err) { cb_occurred += 'error '; - assert.ok(err.message.indexOf('write after end') >= 0); + assert.ok(err.message.includes('write after end')); }); for (var i = 0; i < 11; i++) { - var ret = file.write(i + ''); + const ret = file.write(i + ''); console.error('%d %j', i, ret); // return false when i hits 10 |