diff options
| author | Sam Roberts <vieuxtech@gmail.com> | 2019-02-01 12:23:07 -0800 |
|---|---|---|
| committer | Sam Roberts <vieuxtech@gmail.com> | 2019-02-06 15:18:45 -0800 |
| commit | a046ae5ceddcaaf695df60be5dbc9d725beb6f22 (patch) | |
| tree | 8b5af5fa2240dcd71f0aca8c1bed39defc4d04ab | |
| parent | d597b9193fca7087a6bf1a5eb64c40ac88e852de (diff) | |
| download | android-node-v8-a046ae5ceddcaaf695df60be5dbc9d725beb6f22.tar.gz android-node-v8-a046ae5ceddcaaf695df60be5dbc9d725beb6f22.tar.bz2 android-node-v8-a046ae5ceddcaaf695df60be5dbc9d725beb6f22.zip | |
test: clarify confusion over "client" in comment
Fix perplexing comment. It's not that TLS "clients" don't support
'secureConnect', it's that client sockets created with `new TLSSocket`
(as opposed to `tls.connect()`) don't support that event.
PR-URL: https://github.com/nodejs/node/pull/25508
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
| -rw-r--r-- | test/parallel/test-tls-socket-default-options.js | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/test/parallel/test-tls-socket-default-options.js b/test/parallel/test-tls-socket-default-options.js index f086377b0f..87f785dab5 100644 --- a/test/parallel/test-tls-socket-default-options.js +++ b/test/parallel/test-tls-socket-default-options.js @@ -54,8 +54,9 @@ function test(client, callback) { })); })); - // Client doesn't support the 'secureConnect' event, and doesn't error if - // authentication failed. Caller must explicitly check for failure. + // `new TLSSocket` doesn't support the 'secureConnect' event on client side, + // and doesn't error if authentication failed. Caller must explicitly check + // for failure. (new tls.TLSSocket(null, client)).connect(pair.server.server.address().port) .on('connect', common.mustCall(function() { this.end('hello'); |