summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTaylor Woll <taylor.woll@microsoft.com>2018-01-16 21:17:25 -0800
committerKyle Farnung <kfarnung@microsoft.com>2018-03-12 11:49:31 -0700
commita03c90b661f69200f124718b56b55b0cb3506c71 (patch)
tree3212f9ae3af54bcfba2e457a53a6ca645b0d3aab
parent22b68042590de93109dbc2a4ddaf78caa24c2306 (diff)
downloadandroid-node-v8-a03c90b661f69200f124718b56b55b0cb3506c71.tar.gz
android-node-v8-a03c90b661f69200f124718b56b55b0cb3506c71.tar.bz2
android-node-v8-a03c90b661f69200f124718b56b55b0cb3506c71.zip
n-api,test: add a new.target test to addons-napi
Added a N-API test to verify new.target behavior. PR-URL: https://github.com/nodejs/node/pull/19236 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
-rw-r--r--test/addons-napi/test_new_target/binding.c69
-rw-r--r--test/addons-napi/test_new_target/binding.gyp9
-rw-r--r--test/addons-napi/test_new_target/test.js21
3 files changed, 99 insertions, 0 deletions
diff --git a/test/addons-napi/test_new_target/binding.c b/test/addons-napi/test_new_target/binding.c
new file mode 100644
index 0000000000..a74d4bb2f8
--- /dev/null
+++ b/test/addons-napi/test_new_target/binding.c
@@ -0,0 +1,69 @@
+#include <node_api.h>
+#include "../common.h"
+
+napi_value BaseClass(napi_env env, napi_callback_info info) {
+ napi_value newTargetArg;
+ NAPI_CALL(env, napi_get_new_target(env, info, &newTargetArg));
+ napi_value thisArg;
+ NAPI_CALL(env, napi_get_cb_info(env, info, NULL, NULL, &thisArg, NULL));
+ napi_value undefined;
+ NAPI_CALL(env, napi_get_undefined(env, &undefined));
+
+ // this !== new.target since we are being invoked through super()
+ bool result;
+ NAPI_CALL(env, napi_strict_equals(env, newTargetArg, thisArg, &result));
+ NAPI_ASSERT(env, !result, "this !== new.target");
+
+ // new.target !== undefined because we should be called as a new expression
+ NAPI_ASSERT(env, newTargetArg != NULL, "newTargetArg != NULL");
+ NAPI_CALL(env, napi_strict_equals(env, newTargetArg, undefined, &result));
+ NAPI_ASSERT(env, !result, "new.target !== undefined");
+
+ return thisArg;
+}
+
+napi_value Constructor(napi_env env, napi_callback_info info) {
+ bool result;
+ napi_value newTargetArg;
+ NAPI_CALL(env, napi_get_new_target(env, info, &newTargetArg));
+ size_t argc = 1;
+ napi_value argv;
+ napi_value thisArg;
+ NAPI_CALL(env, napi_get_cb_info(env, info, &argc, &argv, &thisArg, NULL));
+ napi_value undefined;
+ NAPI_CALL(env, napi_get_undefined(env, &undefined));
+
+ // new.target !== undefined because we should be called as a new expression
+ NAPI_ASSERT(env, newTargetArg != NULL, "newTargetArg != NULL");
+ NAPI_CALL(env, napi_strict_equals(env, newTargetArg, undefined, &result));
+ NAPI_ASSERT(env, !result, "new.target !== undefined");
+
+ // arguments[0] should be Constructor itself (test harness passed it)
+ NAPI_CALL(env, napi_strict_equals(env, newTargetArg, argv, &result));
+ NAPI_ASSERT(env, result, "new.target === Constructor");
+
+ return thisArg;
+}
+
+napi_value OrdinaryFunction(napi_env env, napi_callback_info info) {
+ napi_value newTargetArg;
+ NAPI_CALL(env, napi_get_new_target(env, info, &newTargetArg));
+
+ NAPI_ASSERT(env, newTargetArg == NULL, "newTargetArg == NULL");
+
+ napi_value _true;
+ NAPI_CALL(env, napi_get_boolean(env, true, &_true));
+ return _true;
+}
+
+napi_value Init(napi_env env, napi_value exports) {
+ const napi_property_descriptor desc[] = {
+ DECLARE_NAPI_PROPERTY("BaseClass", BaseClass),
+ DECLARE_NAPI_PROPERTY("OrdinaryFunction", OrdinaryFunction),
+ DECLARE_NAPI_PROPERTY("Constructor", Constructor)
+ };
+ NAPI_CALL(env, napi_define_properties(env, exports, 3, desc));
+ return exports;
+}
+
+NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
diff --git a/test/addons-napi/test_new_target/binding.gyp b/test/addons-napi/test_new_target/binding.gyp
new file mode 100644
index 0000000000..23daf50791
--- /dev/null
+++ b/test/addons-napi/test_new_target/binding.gyp
@@ -0,0 +1,9 @@
+{
+ 'targets': [
+ {
+ 'target_name': 'binding',
+ 'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
+ 'sources': [ 'binding.c' ]
+ }
+ ]
+}
diff --git a/test/addons-napi/test_new_target/test.js b/test/addons-napi/test_new_target/test.js
new file mode 100644
index 0000000000..702e8ca8b4
--- /dev/null
+++ b/test/addons-napi/test_new_target/test.js
@@ -0,0 +1,21 @@
+'use strict';
+
+const common = require('../../common');
+const assert = require('assert');
+const binding = require(`./build/${common.buildType}/binding`);
+
+class Class extends binding.BaseClass {
+ constructor() {
+ super();
+ this.method();
+ }
+ method() {
+ this.ok = true;
+ }
+}
+
+assert.ok(new Class() instanceof binding.BaseClass);
+assert.ok(new Class().ok);
+assert.ok(binding.OrdinaryFunction());
+assert.ok(
+ new binding.Constructor(binding.Constructor) instanceof binding.Constructor);