summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2018-05-30 03:50:31 +0000
committerRich Trott <rtrott@gmail.com>2018-06-02 05:17:26 +0200
commit9cd4a23b796617e6920072bae5771f1bbdf22197 (patch)
tree2129706f96a9327b8e779b9a84288edce8cd76ca
parent30650a62d9b883e3ef05aac7e87e202065afee88 (diff)
downloadandroid-node-v8-9cd4a23b796617e6920072bae5771f1bbdf22197.tar.gz
android-node-v8-9cd4a23b796617e6920072bae5771f1bbdf22197.tar.bz2
android-node-v8-9cd4a23b796617e6920072bae5771f1bbdf22197.zip
benchmark: refactor deepequal-set
This is a minor refactor of benchmark/assert/deepequal-set.js to reduce exceptions that need to be made for lint compliance. PR-URL: https://github.com/nodejs/node/pull/21030 Reviewed-By: Michaƫl Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
-rw-r--r--benchmark/assert/deepequal-set.js33
1 files changed, 16 insertions, 17 deletions
diff --git a/benchmark/assert/deepequal-set.js b/benchmark/assert/deepequal-set.js
index e70ddf10e9..6769e5e37f 100644
--- a/benchmark/assert/deepequal-set.js
+++ b/benchmark/assert/deepequal-set.js
@@ -1,9 +1,8 @@
'use strict';
-/* eslint-disable no-restricted-properties */
-
const common = require('../common.js');
-const assert = require('assert');
+const { deepEqual, deepStrictEqual, notDeepEqual, notDeepStrictEqual } =
+ require('assert');
const bench = common.createBenchmark(main, {
n: [5e2],
@@ -48,60 +47,60 @@ function main({ n, len, method }) {
// Empty string falls through to next line as default, mostly for tests.
case 'deepEqual_primitiveOnly':
values = array.map((_, i) => `str_${i}`);
- benchmark(assert.deepEqual, n, values);
+ benchmark(deepEqual, n, values);
break;
case 'deepStrictEqual_primitiveOnly':
values = array.map((_, i) => `str_${i}`);
- benchmark(assert.deepStrictEqual, n, values);
+ benchmark(deepStrictEqual, n, values);
break;
case 'deepEqual_objectOnly':
values = array.map((_, i) => [`str_${i}`, null]);
- benchmark(assert.deepEqual, n, values);
+ benchmark(deepEqual, n, values);
break;
case 'deepStrictEqual_objectOnly':
values = array.map((_, i) => [`str_${i}`, null]);
- benchmark(assert.deepStrictEqual, n, values);
+ benchmark(deepStrictEqual, n, values);
break;
case 'deepEqual_mixed':
values = array.map((_, i) => {
return i % 2 ? [`str_${i}`, null] : `str_${i}`;
});
- benchmark(assert.deepEqual, n, values);
+ benchmark(deepEqual, n, values);
break;
case 'deepStrictEqual_mixed':
values = array.map((_, i) => {
return i % 2 ? [`str_${i}`, null] : `str_${i}`;
});
- benchmark(assert.deepStrictEqual, n, values);
+ benchmark(deepStrictEqual, n, values);
break;
case 'deepEqual_looseMatches':
values = array.map((_, i) => i);
values2 = values.slice().map((v) => String(v));
- benchmark(assert.deepEqual, n, values, values2);
+ benchmark(deepEqual, n, values, values2);
break;
case 'notDeepEqual_primitiveOnly':
values = array.map((_, i) => `str_${i}`);
values2 = values.slice(0);
values2[Math.floor(len / 2)] = 'w00t';
- benchmark(assert.notDeepEqual, n, values, values2);
+ benchmark(notDeepEqual, n, values, values2);
break;
case 'notDeepStrictEqual_primitiveOnly':
values = array.map((_, i) => `str_${i}`);
values2 = values.slice(0);
values2[Math.floor(len / 2)] = 'w00t';
- benchmark(assert.notDeepStrictEqual, n, values, values2);
+ benchmark(notDeepStrictEqual, n, values, values2);
break;
case 'notDeepEqual_objectOnly':
values = array.map((_, i) => [`str_${i}`, null]);
values2 = values.slice(0);
values2[Math.floor(len / 2)] = ['w00t'];
- benchmark(assert.notDeepEqual, n, values, values2);
+ benchmark(notDeepEqual, n, values, values2);
break;
case 'notDeepStrictEqual_objectOnly':
values = array.map((_, i) => [`str_${i}`, null]);
values2 = values.slice(0);
values2[Math.floor(len / 2)] = ['w00t'];
- benchmark(assert.notDeepStrictEqual, n, values, values2);
+ benchmark(notDeepStrictEqual, n, values, values2);
break;
case 'notDeepEqual_mixed':
values = array.map((_, i) => {
@@ -109,7 +108,7 @@ function main({ n, len, method }) {
});
values2 = values.slice();
values2[0] = 'w00t';
- benchmark(assert.notDeepEqual, n, values, values2);
+ benchmark(notDeepEqual, n, values, values2);
break;
case 'notDeepStrictEqual_mixed':
values = array.map((_, i) => {
@@ -117,13 +116,13 @@ function main({ n, len, method }) {
});
values2 = values.slice();
values2[0] = 'w00t';
- benchmark(assert.notDeepStrictEqual, n, values, values2);
+ benchmark(notDeepStrictEqual, n, values, values2);
break;
case 'notDeepEqual_looseMatches':
values = array.map((_, i) => i);
values2 = values.slice().map((v) => String(v));
values2[len - 1] = String(len + 1);
- benchmark(assert.notDeepEqual, n, values, values2);
+ benchmark(notDeepEqual, n, values, values2);
break;
default:
throw new Error(`Unsupported method "${method}"`);