diff options
author | James M Snell <jasnell@gmail.com> | 2018-08-12 15:27:01 -0700 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2018-08-18 16:27:11 -0700 |
commit | 892932f9bdd875006ee248d06ba6be03bd50aeca (patch) | |
tree | 7f189656215108a20e181ae56e7ceeab65cba241 | |
parent | 1744205ff565b490f8db72000028b074cce23d5d (diff) | |
download | android-node-v8-892932f9bdd875006ee248d06ba6be03bd50aeca.tar.gz android-node-v8-892932f9bdd875006ee248d06ba6be03bd50aeca.tar.bz2 android-node-v8-892932f9bdd875006ee248d06ba6be03bd50aeca.zip |
v8: move process.binding('v8') to internalBinding
PR-URL: https://github.com/nodejs/node/pull/22288
Refs: https://github.com/nodejs/node/issues/22160
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
-rw-r--r-- | lib/internal/bootstrap/node.js | 2 | ||||
-rw-r--r-- | lib/v8.js | 2 | ||||
-rw-r--r-- | src/node_v8.cc | 2 | ||||
-rw-r--r-- | test/parallel/test-process-binding-internalbinding-whitelist.js | 1 |
4 files changed, 4 insertions, 3 deletions
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js index e6c4da25b0..32a62171da 100644 --- a/lib/internal/bootstrap/node.js +++ b/lib/internal/bootstrap/node.js @@ -344,7 +344,7 @@ // that are whitelisted for access via process.binding()... this is used // to provide a transition path for modules that are being moved over to // internalBinding. - const internalBindingWhitelist = new SafeSet(['uv', 'http_parser']); + const internalBindingWhitelist = new SafeSet(['uv', 'http_parser', 'v8']); process.binding = function binding(name) { return internalBindingWhitelist.has(name) ? internalBinding(name) : @@ -56,7 +56,7 @@ const { kSpaceUsedSizeIndex, kSpaceAvailableSizeIndex, kPhysicalSpaceSizeIndex -} = process.binding('v8'); +} = internalBinding('v8'); const kNumberOfHeapSpaces = kHeapSpaces.length; diff --git a/src/node_v8.cc b/src/node_v8.cc index fb0a9fea1e..2a661d9549 100644 --- a/src/node_v8.cc +++ b/src/node_v8.cc @@ -200,4 +200,4 @@ void Initialize(Local<Object> target, } // namespace node -NODE_BUILTIN_MODULE_CONTEXT_AWARE(v8, node::Initialize) +NODE_MODULE_CONTEXT_AWARE_INTERNAL(v8, node::Initialize) diff --git a/test/parallel/test-process-binding-internalbinding-whitelist.js b/test/parallel/test-process-binding-internalbinding-whitelist.js index bfb265a299..e8c3b76214 100644 --- a/test/parallel/test-process-binding-internalbinding-whitelist.js +++ b/test/parallel/test-process-binding-internalbinding-whitelist.js @@ -8,3 +8,4 @@ const assert = require('assert'); // process.binding(). assert(process.binding('uv')); assert(process.binding('http_parser')); +assert(process.binding('v8')); |