summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRuben Bridgewater <ruben@bridgewater.de>2018-03-07 00:07:46 +0100
committerRuben Bridgewater <ruben@bridgewater.de>2018-03-11 02:36:35 +0100
commit8181c607e5cd96afc041636ceb37ff6758e8d470 (patch)
tree5764df14a30b22f39794fbad562787a4861d572a
parent97579068b5e00d46f2e376f3f25cd411ea7c40e0 (diff)
downloadandroid-node-v8-8181c607e5cd96afc041636ceb37ff6758e8d470.tar.gz
android-node-v8-8181c607e5cd96afc041636ceb37ff6758e8d470.tar.bz2
android-node-v8-8181c607e5cd96afc041636ceb37ff6758e8d470.zip
test: add regression tests
This makes sure util.isDate and util.isRegExp will not abort in case more than one argument is passed to the utility function. PR-URL: https://github.com/nodejs/node/pull/19188 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
-rw-r--r--test/parallel/test-util.js4
1 files changed, 2 insertions, 2 deletions
diff --git a/test/parallel/test-util.js b/test/parallel/test-util.js
index 10ad1db4ee..a60e0d5b53 100644
--- a/test/parallel/test-util.js
+++ b/test/parallel/test-util.js
@@ -42,7 +42,7 @@ assert.strictEqual(false, util.isArray(Object.create(Array.prototype)));
// isRegExp
assert.strictEqual(true, util.isRegExp(/regexp/));
-assert.strictEqual(true, util.isRegExp(RegExp()));
+assert.strictEqual(true, util.isRegExp(RegExp(), 'foo'));
assert.strictEqual(true, util.isRegExp(new RegExp()));
assert.strictEqual(true, util.isRegExp(context('RegExp')()));
assert.strictEqual(false, util.isRegExp({}));
@@ -52,7 +52,7 @@ assert.strictEqual(false, util.isRegExp(Object.create(RegExp.prototype)));
// isDate
assert.strictEqual(true, util.isDate(new Date()));
-assert.strictEqual(true, util.isDate(new Date(0)));
+assert.strictEqual(true, util.isDate(new Date(0), 'foo'));
assert.strictEqual(true, util.isDate(new (context('Date'))()));
assert.strictEqual(false, util.isDate(Date()));
assert.strictEqual(false, util.isDate({}));