diff options
author | Rich Trott <rtrott@gmail.com> | 2019-01-03 10:34:17 -0800 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-01-06 15:49:19 -0800 |
commit | 7ed790e9dbf7827056b2859a57e9ad72863c1d50 (patch) | |
tree | 62bce3d1e3a1f7ab5a22ffd1a218c38d007e56b6 | |
parent | 6f27f5350caa41b6a174386c07a4f2e72dc94f77 (diff) | |
download | android-node-v8-7ed790e9dbf7827056b2859a57e9ad72863c1d50.tar.gz android-node-v8-7ed790e9dbf7827056b2859a57e9ad72863c1d50.tar.bz2 android-node-v8-7ed790e9dbf7827056b2859a57e9ad72863c1d50.zip |
test: remove flag for test-addon-uv-handle-leak
test-addon-uv-handle-leak only requires worker_threads for the
subprocess which it explicitly calls with --experimental-worker. The
main test itself does not need it. Remove Flags: comment and move
loading of worker_threads into subprocess-only logic.
PR-URL: https://github.com/nodejs/node/pull/25327
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
-rw-r--r-- | test/abort/test-addon-uv-handle-leak.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/abort/test-addon-uv-handle-leak.js b/test/abort/test-addon-uv-handle-leak.js index b67c5f7136..87affeebf2 100644 --- a/test/abort/test-addon-uv-handle-leak.js +++ b/test/abort/test-addon-uv-handle-leak.js @@ -1,11 +1,9 @@ -// Flags: --experimental-worker 'use strict'; const common = require('../common'); const assert = require('assert'); const fs = require('fs'); const path = require('path'); const cp = require('child_process'); -const { Worker } = require('worker_threads'); const { spawnSync } = require('child_process'); // This is a sibling test to test/addons/uv-handle-leak. @@ -19,6 +17,8 @@ if (!fs.existsSync(bindingPath)) if (process.argv[2] === 'child') { + const { Worker } = require('worker_threads'); + // The worker thread loads and then unloads `bindingPath`. Because of this the // symbols in `bindingPath` are lost when the worker thread quits, but the // number of open handles in the worker thread's event loop is assessed in the |