diff options
author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-06-14 01:09:23 +0800 |
---|---|---|
committer | Joyee Cheung <joyeec9h3@gmail.com> | 2019-06-16 23:42:58 +0800 |
commit | 7e5e1c251526a1ee59071f0e312cb2da99454bda (patch) | |
tree | b876d79cdcc0a5ee108b6789aba2291fdbec5a72 | |
parent | 2b8b23067d4211014dd192e6ef774178725c9209 (diff) | |
download | android-node-v8-7e5e1c251526a1ee59071f0e312cb2da99454bda.tar.gz android-node-v8-7e5e1c251526a1ee59071f0e312cb2da99454bda.tar.bz2 android-node-v8-7e5e1c251526a1ee59071f0e312cb2da99454bda.zip |
test: move --cpu-prof tests to sequential
The tests still fail after being split into multiple files,
(2 out of 30 runs in roughly 48 hours) and the causes are missing
target frames in the samples. This patch moves them to sequential
to observe if the flakiness can be fixed when the tests are
run on a system with less load.
If the flake ever shows up again even after the tests are moved
to sequential, we should consider make the test conditions more
lenient - that is, we would only assert that there are *some* frames
in the generated CPU profile but do not look for the target
function there.
PR-URL: https://github.com/nodejs/node/pull/28210
Refs: https://github.com/nodejs/node/issues/27611
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
-rw-r--r-- | test/sequential/test-cpu-prof-default.js (renamed from test/parallel/test-cpu-prof-default.js) | 0 | ||||
-rw-r--r-- | test/sequential/test-cpu-prof-dir-absolute.js (renamed from test/parallel/test-cpu-prof-dir-absolute.js) | 0 | ||||
-rw-r--r-- | test/sequential/test-cpu-prof-dir-and-name.js (renamed from test/parallel/test-cpu-prof-dir-and-name.js) | 0 | ||||
-rw-r--r-- | test/sequential/test-cpu-prof-dir-relative.js (renamed from test/parallel/test-cpu-prof-dir-relative.js) | 0 | ||||
-rw-r--r-- | test/sequential/test-cpu-prof-dir-worker.js (renamed from test/parallel/test-cpu-prof-dir-worker.js) | 0 | ||||
-rw-r--r-- | test/sequential/test-cpu-prof-drained.js (renamed from test/parallel/test-cpu-prof-drained.js) | 0 | ||||
-rw-r--r-- | test/sequential/test-cpu-prof-exit.js (renamed from test/parallel/test-cpu-prof-exit.js) | 0 | ||||
-rw-r--r-- | test/sequential/test-cpu-prof-invalid-options.js (renamed from test/parallel/test-cpu-prof-invalid-options.js) | 0 | ||||
-rw-r--r-- | test/sequential/test-cpu-prof-kill.js (renamed from test/parallel/test-cpu-prof-kill.js) | 0 | ||||
-rw-r--r-- | test/sequential/test-cpu-prof-name.js (renamed from test/parallel/test-cpu-prof-name.js) | 0 | ||||
-rw-r--r-- | test/sequential/test-cpu-prof-worker-argv.js (renamed from test/parallel/test-cpu-prof-worker-argv.js) | 0 |
11 files changed, 0 insertions, 0 deletions
diff --git a/test/parallel/test-cpu-prof-default.js b/test/sequential/test-cpu-prof-default.js index 12c4bc05bb..12c4bc05bb 100644 --- a/test/parallel/test-cpu-prof-default.js +++ b/test/sequential/test-cpu-prof-default.js diff --git a/test/parallel/test-cpu-prof-dir-absolute.js b/test/sequential/test-cpu-prof-dir-absolute.js index ad0842dbc4..ad0842dbc4 100644 --- a/test/parallel/test-cpu-prof-dir-absolute.js +++ b/test/sequential/test-cpu-prof-dir-absolute.js diff --git a/test/parallel/test-cpu-prof-dir-and-name.js b/test/sequential/test-cpu-prof-dir-and-name.js index 7ce775ebc1..7ce775ebc1 100644 --- a/test/parallel/test-cpu-prof-dir-and-name.js +++ b/test/sequential/test-cpu-prof-dir-and-name.js diff --git a/test/parallel/test-cpu-prof-dir-relative.js b/test/sequential/test-cpu-prof-dir-relative.js index 2d679959ef..2d679959ef 100644 --- a/test/parallel/test-cpu-prof-dir-relative.js +++ b/test/sequential/test-cpu-prof-dir-relative.js diff --git a/test/parallel/test-cpu-prof-dir-worker.js b/test/sequential/test-cpu-prof-dir-worker.js index fe72af7416..fe72af7416 100644 --- a/test/parallel/test-cpu-prof-dir-worker.js +++ b/test/sequential/test-cpu-prof-dir-worker.js diff --git a/test/parallel/test-cpu-prof-drained.js b/test/sequential/test-cpu-prof-drained.js index 5be4d1a919..5be4d1a919 100644 --- a/test/parallel/test-cpu-prof-drained.js +++ b/test/sequential/test-cpu-prof-drained.js diff --git a/test/parallel/test-cpu-prof-exit.js b/test/sequential/test-cpu-prof-exit.js index 34b1acff4b..34b1acff4b 100644 --- a/test/parallel/test-cpu-prof-exit.js +++ b/test/sequential/test-cpu-prof-exit.js diff --git a/test/parallel/test-cpu-prof-invalid-options.js b/test/sequential/test-cpu-prof-invalid-options.js index b5f7619cda..b5f7619cda 100644 --- a/test/parallel/test-cpu-prof-invalid-options.js +++ b/test/sequential/test-cpu-prof-invalid-options.js diff --git a/test/parallel/test-cpu-prof-kill.js b/test/sequential/test-cpu-prof-kill.js index cee66a6256..cee66a6256 100644 --- a/test/parallel/test-cpu-prof-kill.js +++ b/test/sequential/test-cpu-prof-kill.js diff --git a/test/parallel/test-cpu-prof-name.js b/test/sequential/test-cpu-prof-name.js index 58d9a0ec15..58d9a0ec15 100644 --- a/test/parallel/test-cpu-prof-name.js +++ b/test/sequential/test-cpu-prof-name.js diff --git a/test/parallel/test-cpu-prof-worker-argv.js b/test/sequential/test-cpu-prof-worker-argv.js index ad88a2eeb0..ad88a2eeb0 100644 --- a/test/parallel/test-cpu-prof-worker-argv.js +++ b/test/sequential/test-cpu-prof-worker-argv.js |