summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRuben Bridgewater <ruben@bridgewater.de>2018-05-07 02:18:14 +0200
committerRuben Bridgewater <ruben@bridgewater.de>2018-05-18 15:32:05 +0200
commit7afb73715f161ea14924eceb6f03b502f32ac8fd (patch)
tree767828fec5869c4a7f279bb856c2da96f18bef54
parentdc1737881e66acbbfc9cce71a5008e1a2838b0c7 (diff)
downloadandroid-node-v8-7afb73715f161ea14924eceb6f03b502f32ac8fd.tar.gz
android-node-v8-7afb73715f161ea14924eceb6f03b502f32ac8fd.tar.bz2
android-node-v8-7afb73715f161ea14924eceb6f03b502f32ac8fd.zip
lib: remove unnecessary require
The call to url was not necessary since the `url` module itself was already taking care of this. PR-URL: https://github.com/nodejs/node/pull/20567 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
-rw-r--r--lib/internal/bootstrap/node.js4
-rw-r--r--lib/url.js2
2 files changed, 2 insertions, 4 deletions
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
index 96d0733198..bdd2edce86 100644
--- a/lib/internal/bootstrap/node.js
+++ b/lib/internal/bootstrap/node.js
@@ -90,10 +90,6 @@
setupGlobalURL();
}
- // Ensure setURLConstructor() is called before the native
- // URL::ToObject() method is used.
- NativeModule.require('internal/url');
-
// On OpenBSD process.execPath will be relative unless we
// get the full path before process.execPath is used.
if (process.platform === 'openbsd') {
diff --git a/lib/url.js b/lib/url.js
index c517ba7ab3..3a2c3c01ea 100644
--- a/lib/url.js
+++ b/lib/url.js
@@ -30,6 +30,8 @@ const {
ERR_INVALID_ARG_TYPE
} = require('internal/errors').codes;
+// This ensures setURLConstructor() is called before the native
+// URL::ToObject() method is used.
const { spliceOne } = require('internal/util');
// WHATWG URL implementation provided by internal/url