diff options
author | cjihrig <cjihrig@gmail.com> | 2018-12-14 22:22:40 -0500 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2018-12-16 20:30:50 -0800 |
commit | 707b0a85344e16f38a6cded922df30361eaedd83 (patch) | |
tree | 84de938319f0d2dc407be220435102723d48fc10 | |
parent | 18f2bf7f9bd183f7baf08a705035fc99580a2c40 (diff) | |
download | android-node-v8-707b0a85344e16f38a6cded922df30361eaedd83.tar.gz android-node-v8-707b0a85344e16f38a6cded922df30361eaedd83.tar.bz2 android-node-v8-707b0a85344e16f38a6cded922df30361eaedd83.zip |
tools: enable no-useless-constructor lint rule
This commit enables ESLint's no-useless-constructor rule. Note
that the documentation examples that only include constructor
calls were left in tact.
PR-URL: https://github.com/nodejs/node/pull/25055
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
-rw-r--r-- | .eslintrc.js | 1 | ||||
-rw-r--r-- | doc/api/stream.md | 10 | ||||
-rw-r--r-- | lib/perf_hooks.js | 2 | ||||
-rw-r--r-- | lib/v8.js | 4 | ||||
-rw-r--r-- | test/parallel/test-stream-writable-null.js | 4 |
5 files changed, 6 insertions, 15 deletions
diff --git a/.eslintrc.js b/.eslintrc.js index 370dfaed68..36e0ce2196 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -235,6 +235,7 @@ module.exports = { }], 'no-useless-call': 'error', 'no-useless-concat': 'error', + 'no-useless-constructor': 'error', 'no-useless-escape': 'error', 'no-useless-return': 'error', 'no-void': 'error', diff --git a/doc/api/stream.md b/doc/api/stream.md index c1f23adae5..5a9e304dc0 100644 --- a/doc/api/stream.md +++ b/doc/api/stream.md @@ -1450,6 +1450,7 @@ of the four basic stream classes (`stream.Writable`, `stream.Readable`, `stream.Duplex`, or `stream.Transform`), making sure they call the appropriate parent class constructor: +<!-- eslint-disable no-useless-constructor --> ```js const { Writable } = require('stream'); @@ -1547,6 +1548,7 @@ changes: * `autoDestroy` {boolean} Whether this stream should automatically call `.destroy()` on itself after ending. **Default:** `false`. +<!-- eslint-disable no-useless-constructor --> ```js const { Writable } = require('stream'); @@ -1718,11 +1720,6 @@ required elements of a custom [`Writable`][] stream instance: const { Writable } = require('stream'); class MyWritable extends Writable { - constructor(options) { - super(options); - // ... - } - _write(chunk, encoding, callback) { if (chunk.toString().indexOf('a') >= 0) { callback(new Error('chunk is invalid')); @@ -1806,6 +1803,7 @@ changes: * `autoDestroy` {boolean} Whether this stream should automatically call `.destroy()` on itself after ending. **Default:** `false`. +<!-- eslint-disable no-useless-constructor --> ```js const { Readable } = require('stream'); @@ -2064,6 +2062,7 @@ changes: * `writableHighWaterMark` {number} Sets `highWaterMark` for the writable side of the stream. Has no effect if `highWaterMark` is provided. +<!-- eslint-disable no-useless-constructor --> ```js const { Duplex } = require('stream'); @@ -2218,6 +2217,7 @@ output on the `Readable` side is not consumed. * `flush` {Function} Implementation for the [`stream._flush()`][stream-_flush] method. +<!-- eslint-disable no-useless-constructor --> ```js const { Transform } = require('stream'); diff --git a/lib/perf_hooks.js b/lib/perf_hooks.js index 9b40c8f977..cb1640ef9b 100644 --- a/lib/perf_hooks.js +++ b/lib/perf_hooks.js @@ -142,8 +142,6 @@ function getMilestoneTimestamp(milestoneIdx) { } class PerformanceNodeTiming { - constructor() {} - get name() { return 'node'; } @@ -172,10 +172,6 @@ class DefaultSerializer extends Serializer { } class DefaultDeserializer extends Deserializer { - constructor(buffer) { - super(buffer); - } - _readHostObject() { const typeIndex = this.readUint32(); const ctor = arrayBufferViewTypes[typeIndex]; diff --git a/test/parallel/test-stream-writable-null.js b/test/parallel/test-stream-writable-null.js index 63e122a3b4..dc0f569ee6 100644 --- a/test/parallel/test-stream-writable-null.js +++ b/test/parallel/test-stream-writable-null.js @@ -5,10 +5,6 @@ const assert = require('assert'); const stream = require('stream'); class MyWritable extends stream.Writable { - constructor(opt) { - super(opt); - } - _write(chunk, encoding, callback) { assert.notStrictEqual(chunk, null); callback(); |