diff options
| author | cjihrig <cjihrig@gmail.com> | 2018-08-23 11:18:08 -0400 |
|---|---|---|
| committer | cjihrig <cjihrig@gmail.com> | 2018-08-28 20:38:58 -0400 |
| commit | 6e942e73536232a71a47b81565ecf27be24958f4 (patch) | |
| tree | e47b8b706445d008b4dae194d2529c87086f9b22 | |
| parent | dca2f9849c853b8a151732022d853d1a44dc708e (diff) | |
| download | android-node-v8-6e942e73536232a71a47b81565ecf27be24958f4.tar.gz android-node-v8-6e942e73536232a71a47b81565ecf27be24958f4.tar.bz2 android-node-v8-6e942e73536232a71a47b81565ecf27be24958f4.zip | |
fs: make fs_event_wrap binding internal
PR-URL: https://github.com/nodejs/node/pull/22480
Refs: https://github.com/nodejs/node/issues/22160
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
| -rw-r--r-- | lib/internal/bootstrap/node.js | 1 | ||||
| -rw-r--r-- | lib/internal/fs/watchers.js | 3 | ||||
| -rw-r--r-- | src/fs_event_wrap.cc | 2 | ||||
| -rw-r--r-- | test/sequential/test-async-wrap-getasyncid.js | 2 |
4 files changed, 5 insertions, 3 deletions
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js index 3e3eaa5b60..96b620d057 100644 --- a/lib/internal/bootstrap/node.js +++ b/lib/internal/bootstrap/node.js @@ -348,6 +348,7 @@ // internalBinding. const internalBindingWhitelist = new SafeSet([ + 'fs_event_wrap', 'uv', 'http_parser', 'process_wrap', diff --git a/lib/internal/fs/watchers.js b/lib/internal/fs/watchers.js index 90ea3971aa..8f8cb5249b 100644 --- a/lib/internal/fs/watchers.js +++ b/lib/internal/fs/watchers.js @@ -1,11 +1,12 @@ 'use strict'; const errors = require('internal/errors'); +const { internalBinding } = require('internal/bootstrap/loaders'); const { kFsStatsFieldsLength, StatWatcher: _StatWatcher } = process.binding('fs'); -const { FSEvent } = process.binding('fs_event_wrap'); +const { FSEvent } = internalBinding('fs_event_wrap'); const { EventEmitter } = require('events'); const { getStatsFromBinding, diff --git a/src/fs_event_wrap.cc b/src/fs_event_wrap.cc index e0cdab4d3e..11a1036d60 100644 --- a/src/fs_event_wrap.cc +++ b/src/fs_event_wrap.cc @@ -235,4 +235,4 @@ void FSEventWrap::OnEvent(uv_fs_event_t* handle, const char* filename, } // anonymous namespace } // namespace node -NODE_BUILTIN_MODULE_CONTEXT_AWARE(fs_event_wrap, node::FSEventWrap::Initialize) +NODE_MODULE_CONTEXT_AWARE_INTERNAL(fs_event_wrap, node::FSEventWrap::Initialize) diff --git a/test/sequential/test-async-wrap-getasyncid.js b/test/sequential/test-async-wrap-getasyncid.js index 65fe2015a0..eb4b5aef25 100644 --- a/test/sequential/test-async-wrap-getasyncid.js +++ b/test/sequential/test-async-wrap-getasyncid.js @@ -88,7 +88,7 @@ function testInitialized(req, ctor_name) { { - const FSEvent = process.binding('fs_event_wrap').FSEvent; + const FSEvent = internalBinding('fs_event_wrap').FSEvent; testInitialized(new FSEvent(), 'FSEvent'); } |