summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2019-11-06 12:35:56 +0100
committerAnna Henningsen <anna@addaleax.net>2019-11-06 12:45:56 +0100
commit369803175307dae7fd6b983d9270619f11bd7214 (patch)
treef3872a899f97fbdfd022d24183decfc9da92534e
parentd26a74dca0d04a827140a33a43c38a55f12c7296 (diff)
downloadandroid-node-v8-369803175307dae7fd6b983d9270619f11bd7214.tar.gz
android-node-v8-369803175307dae7fd6b983d9270619f11bd7214.tar.bz2
android-node-v8-369803175307dae7fd6b983d9270619f11bd7214.zip
Revert "test: test configure ninja"
This reverts commit 85dd9e8333f227dcdcbe86ae45f239a2b5cef030. `make test` should never change the current set of `configure` flags. Refs: https://github.com/nodejs/node/pull/30033 PR-URL: https://github.com/nodejs/node/pull/30295 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
-rw-r--r--Makefile2
-rw-r--r--test/tools/test-js2c.py (renamed from test/tools/test_js2c.py)0
-rw-r--r--test/tools/test_configure.py29
3 files changed, 1 insertions, 30 deletions
diff --git a/Makefile b/Makefile
index d46b4a0c18..8d4e6bbe64 100644
--- a/Makefile
+++ b/Makefile
@@ -300,7 +300,7 @@ jstest: build-addons build-js-native-api-tests build-node-api-tests ## Runs addo
.PHONY: tooltest
tooltest:
- @$(PYTHON) -m unittest discover -s ./test/tools
+ @$(PYTHON) test/tools/test-js2c.py
.PHONY: coverage-run-js
coverage-run-js:
diff --git a/test/tools/test_js2c.py b/test/tools/test-js2c.py
index 2045621170..2045621170 100644
--- a/test/tools/test_js2c.py
+++ b/test/tools/test-js2c.py
diff --git a/test/tools/test_configure.py b/test/tools/test_configure.py
deleted file mode 100644
index c4e65192c9..0000000000
--- a/test/tools/test_configure.py
+++ /dev/null
@@ -1,29 +0,0 @@
-import sys
-import os
-import unittest
-import subprocess
-
-
-class ConfigureTests(unittest.TestCase):
- def setUp(self):
- self.working_dir = os.path.abspath(
- os.path.join(
- os.path.dirname(__file__),
- '..', '..'
- )
- )
-
- def test_ninja(self):
- subprocess.check_call(
- './configure --ninja',
- cwd=self.working_dir,
- shell=True,
- stdout=subprocess.PIPE,
- stderr=subprocess.PIPE
- )
-
-
-if (__name__ == '__main__' and
- sys.platform in ['linux', 'linux2', 'darwin', 'cygwin']):
-
- unittest.main()