diff options
| author | Jon Moss <me@jonathanmoss.me> | 2018-07-13 10:45:42 -0400 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-07-13 21:46:09 +0200 |
| commit | 2d950701a14638480d0e375180e6dff4b50a709b (patch) | |
| tree | 40b5a84cd45383eb73b15e1ab14b86881b6267bf | |
| parent | 57e301539bff2599974b7269a56377330c9b730e (diff) | |
| download | android-node-v8-2d950701a14638480d0e375180e6dff4b50a709b.tar.gz android-node-v8-2d950701a14638480d0e375180e6dff4b50a709b.tar.bz2 android-node-v8-2d950701a14638480d0e375180e6dff4b50a709b.zip | |
test: fix weird string error
Previously getting this error when running `tap2junit` (what parses our
`.tap` files in CI):
```
Traceback (most recent call last):
File "/usr/local/bin/tap2junit", line 11, in <module>
sys.exit(main())
File "/usr/local/lib/python2.7/site-packages/tap2junit/__main__.py", line 46, in main
result.to_file(args.output, [result], prettyprint=False)
File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 289, in to_file
test_suites, prettyprint=prettyprint, encoding=encoding)
File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 257, in to_xml_string
ts_xml = ts.build_xml_doc(encoding=encoding)
File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 221, in build_xml_doc
attrs['message'] = decode(case.skipped_message, encoding)
File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 68, in decode
ret = unicode(var)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 11: ordinal not in range(128)
```
PR-URL: https://github.com/nodejs/node/pull/21793
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
| -rw-r--r-- | test/parallel/test-stdio-pipe-access.js | 2 | ||||
| -rw-r--r-- | test/parallel/test-stdio-pipe-redirect.js | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/test/parallel/test-stdio-pipe-access.js b/test/parallel/test-stdio-pipe-access.js index d32c5f0ba9..084fa4c038 100644 --- a/test/parallel/test-stdio-pipe-access.js +++ b/test/parallel/test-stdio-pipe-access.js @@ -1,7 +1,7 @@ 'use strict'; const common = require('../common'); if (!common.isMainThread) - common.skip('Workers don’t have process-like stdio'); + common.skip("Workers don't have process-like stdio"); // Test if Node handles acessing process.stdin if it is a redirected // pipe without deadlocking diff --git a/test/parallel/test-stdio-pipe-redirect.js b/test/parallel/test-stdio-pipe-redirect.js index 60f16b5cb2..fbde6ef808 100644 --- a/test/parallel/test-stdio-pipe-redirect.js +++ b/test/parallel/test-stdio-pipe-redirect.js @@ -1,7 +1,7 @@ 'use strict'; const common = require('../common'); if (!common.isMainThread) - common.skip('Workers don’t have process-like stdio'); + common.skip("Workers don't have process-like stdio"); // Test if Node handles redirecting one child process stdout to another // process stdin without crashing. |