diff options
| author | cjihrig <cjihrig@gmail.com> | 2019-07-29 04:56:59 -1000 |
|---|---|---|
| committer | cjihrig <cjihrig@gmail.com> | 2019-07-31 05:40:33 -1000 |
| commit | 2abdfc5d7eba620a84a1aea3804beb6de28e19fa (patch) | |
| tree | c6e49de269e5319da098ce82d0e80e344432993f | |
| parent | 7435dc8b2ba2bed4d6a8c1b6474f21c7219b3238 (diff) | |
| download | android-node-v8-2abdfc5d7eba620a84a1aea3804beb6de28e19fa.tar.gz android-node-v8-2abdfc5d7eba620a84a1aea3804beb6de28e19fa.tar.bz2 android-node-v8-2abdfc5d7eba620a84a1aea3804beb6de28e19fa.zip | |
doc: revoke DEP0089
Using the legacy assert module is not discouraged. Revoke
DEP0089 to avoid user confusion.
PR-URL: https://github.com/nodejs/node/pull/28892
Fixes: https://github.com/nodejs/node/issues/28780
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
| -rw-r--r-- | doc/api/deprecations.md | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index d8d0036730..683237a218 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -1780,6 +1780,9 @@ cause a lot of issues. See <https://github.com/nodejs/node/issues/14328>. ### DEP0089: require('assert') <!-- YAML changes: + - version: REPLACEME + pr-url: https://github.com/nodejs/node/pull/28892 + description: Deprecation revoked. - version: - v9.9.0 - v10.0.0 @@ -1787,11 +1790,11 @@ changes: description: Documentation-only deprecation. --> -Type: Documentation-only +Type: Deprecation revoked -Importing assert directly is not recommended as the exposed functions will use -loose equality checks. Use `require('assert').strict` instead. The API is the -same as the legacy assert but it will always use strict equality checks. +Importing assert directly was not recommended as the exposed functions use +loose equality checks. The deprecation was revoked because use of the `assert` +module is not discouraged, and the deprecation caused end user confusion. <a id="DEP0090"></a> ### DEP0090: Invalid GCM authentication tag lengths |