diff options
author | cjihrig <cjihrig@gmail.com> | 2019-01-07 14:11:47 -0500 |
---|---|---|
committer | cjihrig <cjihrig@gmail.com> | 2019-01-10 09:00:22 -0500 |
commit | 29d3d1ea135c5d5692c3fcd9fb9091efa1db5760 (patch) | |
tree | 658d24a552d774d6ea6ed7c066bd5cbaebd11ce0 | |
parent | a665d13ad9fe40092be74d32652c1301b1db7550 (diff) | |
download | android-node-v8-29d3d1ea135c5d5692c3fcd9fb9091efa1db5760.tar.gz android-node-v8-29d3d1ea135c5d5692c3fcd9fb9091efa1db5760.tar.bz2 android-node-v8-29d3d1ea135c5d5692c3fcd9fb9091efa1db5760.zip |
lib: move DEP0029 to end of life
PR-URL: https://github.com/nodejs/node/pull/25377
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
-rw-r--r-- | doc/api/deprecations.md | 9 | ||||
-rw-r--r-- | doc/api/util.md | 12 | ||||
-rw-r--r-- | lib/util.js | 14 | ||||
-rw-r--r-- | test/parallel/test-util.js | 8 |
4 files changed, 7 insertions, 36 deletions
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index eef4afdd03..7244387e3c 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -632,6 +632,9 @@ Type: End-of-Life ### DEP0029: util.error() <!-- YAML changes: + - version: REPLACEME + pr-url: https://github.com/nodejs/node/pull/xxxxx + description: End-of-Life. - version: - v4.8.6 - v6.12.0 @@ -642,10 +645,9 @@ changes: description: Runtime deprecation. --> -Type: Runtime +Type: End-of-Life -The [`util.error()`][] API is deprecated. Please use [`console.error()`][] -instead. +`util.error()` has been removed. Please use [`console.error()`][] instead. <a id="DEP0030"></a> ### DEP0030: SlowBuffer @@ -2397,7 +2399,6 @@ Setting the TLS ServerName to an IP address is not permitted by [`url.parse()`]: url.html#url_url_parse_urlstring_parsequerystring_slashesdenotehost [`url.resolve()`]: url.html#url_url_resolve_from_to [`util._extend()`]: util.html#util_util_extend_target_source -[`util.error()`]: util.html#util_util_error_strings [`util.getSystemErrorName()`]: util.html#util_util_getsystemerrorname_err [`util.inspect()`]: util.html#util_util_inspect_object_options [`util.inspect.custom`]: util.html#util_util_inspect_custom diff --git a/doc/api/util.md b/doc/api/util.md index e5543d189c..f028699f5a 100644 --- a/doc/api/util.md +++ b/doc/api/util.md @@ -1714,18 +1714,6 @@ Node.js modules. The community found and used it anyway. It is deprecated and should not be used in new code. JavaScript comes with very similar built-in functionality through [`Object.assign()`]. -### util.error([...strings]) -<!-- YAML -added: v0.3.0 -deprecated: v0.11.3 ---> - -> Stability: 0 - Deprecated: Use [`console.error()`][] instead. - -* `...strings` {string} The message to print to `stderr` - -Deprecated predecessor of `console.error`. - ### util.isArray(object) <!-- YAML added: v0.6.0 diff --git a/lib/util.js b/lib/util.js index 160904d28a..6333dcc8ba 100644 --- a/lib/util.js +++ b/lib/util.js @@ -324,13 +324,6 @@ function _extend(target, source) { return target; } -// Deprecated old stuff. -function error(...args) { - for (var i = 0, len = args.length; i < len; ++i) { - process.stderr.write(`${args[i]}\n`); - } -} - function callbackifyOnRejected(reason, cb) { // `!reason` guard inspired by bluebird (Ref: https://goo.gl/t5IS6M). // Because `null` is a special error value in callbacks which means "no error @@ -421,10 +414,5 @@ module.exports = exports = { promisify, TextDecoder, TextEncoder, - types, - - // Deprecated Old Stuff - error: deprecate(error, - 'util.error is deprecated. Use console.error instead.', - 'DEP0029') + types }; diff --git a/test/parallel/test-util.js b/test/parallel/test-util.js index 28c4018d73..39377f33cf 100644 --- a/test/parallel/test-util.js +++ b/test/parallel/test-util.js @@ -21,7 +21,7 @@ 'use strict'; // Flags: --expose-internals -const common = require('../common'); +require('../common'); const assert = require('assert'); const util = require('util'); const errors = require('internal/errors'); @@ -144,12 +144,6 @@ assert.strictEqual(util.isFunction(function() {}), true); assert.strictEqual(util.isFunction(), false); assert.strictEqual(util.isFunction('string'), false); -common.expectWarning('DeprecationWarning', [ - ['util.error is deprecated. Use console.error instead.', 'DEP0029'] -]); - -util.error('test'); - { assert.strictEqual(util.types.isNativeError(new Error()), true); assert.strictEqual(util.types.isNativeError(new TypeError()), true); |