diff options
author | Chris Burkhart <christide@christide.com> | 2016-12-21 09:32:21 -0800 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2017-03-24 16:07:35 -0700 |
commit | 2141d374527337f7e1c74c9efad217b017d945cf (patch) | |
tree | 4c26cafce830334439a2dd786e3e10e45dd7bea6 | |
parent | cfc8422a68c92808a4a2aee374623bebc768522a (diff) | |
download | android-node-v8-2141d374527337f7e1c74c9efad217b017d945cf.tar.gz android-node-v8-2141d374527337f7e1c74c9efad217b017d945cf.tar.bz2 android-node-v8-2141d374527337f7e1c74c9efad217b017d945cf.zip |
events: update and clarify error message
Update error message that's thrown when no error listeners are attached
to an emitter.
PR-URL: https://github.com/nodejs/node/pull/10387
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
-rw-r--r-- | lib/events.js | 4 | ||||
-rw-r--r-- | test/parallel/test-event-emitter-errors.js | 8 |
2 files changed, 8 insertions, 4 deletions
diff --git a/lib/events.js b/lib/events.js index dfd0ed57d4..eabf5c2cc7 100644 --- a/lib/events.js +++ b/lib/events.js @@ -171,7 +171,7 @@ EventEmitter.prototype.emit = function emit(type) { er = arguments[1]; if (domain) { if (!er) - er = new Error('Uncaught, unspecified "error" event'); + er = new Error('Unhandled "error" event'); if (typeof er === 'object' && er !== null) { er.domainEmitter = this; er.domain = domain; @@ -182,7 +182,7 @@ EventEmitter.prototype.emit = function emit(type) { throw er; // Unhandled 'error' event } else { // At least give some kind of context to the user - var err = new Error('Uncaught, unspecified "error" event. (' + er + ')'); + const err = new Error('Unhandled "error" event. (' + er + ')'); err.context = er; throw err; } diff --git a/test/parallel/test-event-emitter-errors.js b/test/parallel/test-event-emitter-errors.js index 2b4a93ae98..be4f4007f0 100644 --- a/test/parallel/test-event-emitter-errors.js +++ b/test/parallel/test-event-emitter-errors.js @@ -5,6 +5,10 @@ const assert = require('assert'); const EE = new EventEmitter(); -assert.throws(function() { +assert.throws(() => { EE.emit('error', 'Accepts a string'); -}, /Accepts a string/); +}, /^Error: Unhandled "error" event\. \(Accepts a string\)$/); + +assert.throws(() => { + EE.emit('error', {message: 'Error!'}); +}, /^Error: Unhandled "error" event\. \(\[object Object\]\)$/); |