diff options
author | Rich Trott <rtrott@gmail.com> | 2018-02-17 19:25:07 -0800 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2018-02-21 00:28:10 -0800 |
commit | 1b83a9df054a0d5bac28fef96bd0598d86dae6d8 (patch) | |
tree | 954f5219c0fdfbea36c9f5b2d63bf1ffa2e8b9ad | |
parent | d28edf97fa5cb863b5497cc3964c103f782d8b62 (diff) | |
download | android-node-v8-1b83a9df054a0d5bac28fef96bd0598d86dae6d8.tar.gz android-node-v8-1b83a9df054a0d5bac28fef96bd0598d86dae6d8.tar.bz2 android-node-v8-1b83a9df054a0d5bac28fef96bd0598d86dae6d8.zip |
doc: update onboarding.md for faster exercise completion
Note that the CI run for the exercise can be minimal.
PR-URL: https://github.com/nodejs/node/pull/18846
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
-rw-r--r-- | doc/onboarding.md | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/doc/onboarding.md b/doc/onboarding.md index 296f9db7d0..e2a05f2ccd 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -200,7 +200,10 @@ onboarding session. * Collaborators are in alphabetical order by GitHub username. * Optionally, include your personal pronouns. * Label your pull request with the `doc` subsystem label. -* Run CI on your PR. +* Run CI on the PR. Because the PR does not affect any code, use the + `node-test-pull-request-lite` CI task. Alternatively, use the usual + `node-test-pull-request` CI task and cancel it after the linter and one other + subtask have passed. * After one or two approvals, land the PR (PRs of this type do not need to wait for 48/72 hours to land). * Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:` |