diff options
| author | Vse Mozhet Byt <vsemozhetbyt@gmail.com> | 2018-10-04 01:12:23 +0300 |
|---|---|---|
| committer | Vse Mozhet Byt <vsemozhetbyt@gmail.com> | 2018-10-07 11:58:08 +0300 |
| commit | 1a18e3572e5403f6f665232bcf70d7cbcc270994 (patch) | |
| tree | 0cf2afc0481bfc6c1959fd910a32d1b8164d40ef | |
| parent | 061e09891cd5115641b5c3199a5f457b519ec77b (diff) | |
| download | android-node-v8-1a18e3572e5403f6f665232bcf70d7cbcc270994.tar.gz android-node-v8-1a18e3572e5403f6f665232bcf70d7cbcc270994.tar.bz2 android-node-v8-1a18e3572e5403f6f665232bcf70d7cbcc270994.zip | |
doc: update author-ready label terms
PR-URL: https://github.com/nodejs/node/pull/23249
Refs: https://github.com/nodejs/node/pull/22255
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 9 | ||||
| -rw-r--r-- | doc/onboarding.md | 3 |
2 files changed, 7 insertions, 5 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index fb1b5182b3..7a435c6478 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -83,10 +83,11 @@ necessary. ### Author ready pull requests A pull request that is still awaiting the minimum review time is considered -_author ready_ as soon as the CI has been started, it has at least one approval, -and it has no outstanding review comments. Please always make sure to add the -`author ready` label to the PR in that case and remove it again as soon as that -condition is not met anymore. +_author ready_ as soon as the CI has been started, it has at least two approvals +(one Collaborator approval is enough if the pull request has been open for more +than 7 days), and it has no outstanding review comments. Please always make sure +to add the `author ready` label to the PR in that case and remove it again as +soon as that condition is not met anymore. ### Handling own pull requests diff --git a/doc/onboarding.md b/doc/onboarding.md index 0c46318a78..b08aabfff7 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -99,7 +99,8 @@ onboarding session. * Please add the `author-ready` label for PRs where: * the CI has been started (not necessarily finished), * no outstanding review comments exist and - * at least one collaborator approved the PR. + * at least two Collaborators approved the PR (one Collaborator approval is + enough if the pull request has been open for more than 7 days). * See [Who to CC in the issue tracker][who-to-cc]. * This will come more naturally over time |