diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2019-02-21 15:32:55 +0100 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-02-28 05:21:02 +0100 |
| commit | 197690972c3cb8d193bfa3e1a99f3d8b4c414ee1 (patch) | |
| tree | 57f0bef0d9fa737e39c61f5ffc5f8e9443a7d086 | |
| parent | ff64c6722f03cb442859bb7f1bfef8a3adf09119 (diff) | |
| download | android-node-v8-197690972c3cb8d193bfa3e1a99f3d8b4c414ee1.tar.gz android-node-v8-197690972c3cb8d193bfa3e1a99f3d8b4c414ee1.tar.bz2 android-node-v8-197690972c3cb8d193bfa3e1a99f3d8b4c414ee1.zip | |
repl: add new line on ctrl+d
Currently the repl ends on the same line which procudes a weird
output. To prevent that, just add a new line in case of ctrl+d.
PR-URL: https://github.com/nodejs/node/pull/26240
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
| -rw-r--r-- | lib/repl.js | 5 | ||||
| -rw-r--r-- | test/parallel/test-repl-save-load.js | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/lib/repl.js b/lib/repl.js index f579c6b18d..3d0c367918 100644 --- a/lib/repl.js +++ b/lib/repl.js @@ -700,6 +700,11 @@ function REPLServer(prompt, return; } if (!self.editorMode || !self.terminal) { + // Before exiting, make sure to clear the line. + if (key.ctrl && key.name === 'd' && + self.cursor === 0 && self.line.length === 0) { + self.clearLine(); + } ttyWrite(d, key); return; } diff --git a/test/parallel/test-repl-save-load.js b/test/parallel/test-repl-save-load.js index 2767c0f026..7d6f28548f 100644 --- a/test/parallel/test-repl-save-load.js +++ b/test/parallel/test-repl-save-load.js @@ -70,7 +70,7 @@ assert.strictEqual(fs.readFileSync(saveFileName, 'utf8'), putIn.run([`.save ${saveFileName}`]); replServer.close(); assert.strictEqual(fs.readFileSync(saveFileName, 'utf8'), - `${cmds.join('\n')}\n`); + `${cmds.join('\n')}\n\n`); } // make sure that the REPL data is "correct" |