diff options
author | Rich Trott <rtrott@gmail.com> | 2017-04-13 12:47:55 -0700 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2017-04-16 13:41:44 -0700 |
commit | 189afc8dc2a4a01e6e97493e167ad6d2db6ff065 (patch) | |
tree | 00ec30b4d8a6acbd4c514a04837139bcd50e355e | |
parent | b837bd279232d7d8f105e5413161a2bf29231d8a (diff) | |
download | android-node-v8-189afc8dc2a4a01e6e97493e167ad6d2db6ff065.tar.gz android-node-v8-189afc8dc2a4a01e6e97493e167ad6d2db6ff065.tar.bz2 android-node-v8-189afc8dc2a4a01e6e97493e167ad6d2db6ff065.zip |
test: enable setuid/setgid test
Refactor test for situations where it was expected to fail.
Move from disabled directory to parallel.
PR-URL: https://github.com/nodejs/node/pull/12403
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
-rw-r--r-- | test/parallel/test-process-setuid-setgid.js (renamed from test/disabled/test-setuidgid.js) | 56 |
1 files changed, 40 insertions, 16 deletions
diff --git a/test/disabled/test-setuidgid.js b/test/parallel/test-process-setuid-setgid.js index 25d29e7981..38a677970c 100644 --- a/test/disabled/test-setuidgid.js +++ b/test/parallel/test-process-setuid-setgid.js @@ -20,25 +20,49 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. 'use strict'; -// Requires special privileges const common = require('../common'); + const assert = require('assert'); -var oldgid = process.getgid(); -process.setgid('nobody'); -var newgid = process.getgid(); -assert.notStrictEqual(newgid, oldgid, 'gids expected to be different'); +if (common.isWindows) { + // uid/gid functions are POSIX only + assert.strictEqual(process.getuid, undefined); + assert.strictEqual(process.setuid, undefined); + assert.strictEqual(process.getgid, undefined); + assert.strictEqual(process.setgid, undefined); + return; +} -var olduid = process.getuid(); -process.setuid('nobody'); -var newuid = process.getuid(); -assert.notStrictEqual(newuid, olduid, 'uids expected to be different'); - -try { - process.setuid('nobody1234'); -} catch (e) { - assert.strictEqual(e.message, - 'failed to resolve group', - 'unexpected error message' +assert.throws(() => { + process.setuid('fhqwhgadshgnsdhjsdbkhsdabkfabkveybvf'); +}, /^Error: setuid user id does not exist$/); + +// If we're not running as super user... +if (process.getuid() !== 0) { + assert.doesNotThrow(() => { + process.getgid(); + process.getuid(); + }); + + assert.throws( + () => { process.setgid('nobody'); }, + /^Error: (EPERM, .+|setgid group id does not exist)$/ ); + + assert.throws( + () => { process.setuid('nobody'); }, + /^Error: EPERM, / + ); + return; } + +// If we are running as super user... +const oldgid = process.getgid(); +process.setgid('nobody'); +const newgid = process.getgid(); +assert.notStrictEqual(newgid, oldgid); + +const olduid = process.getuid(); +process.setuid('nobody'); +const newuid = process.getuid(); +assert.notStrictEqual(newuid, olduid); |