diff options
author | Robert Nagy <ronagy@icloud.com> | 2019-09-07 23:29:18 +0200 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-09-22 18:05:54 -0700 |
commit | 1665a9330c0fa9f4a79c900e6250938ac8d7a9e5 (patch) | |
tree | e5830774edc0e9eacb39ea9e28244be6d5de9ea5 | |
parent | 34a61d563088c97f13e193d00c91cd893f1479b8 (diff) | |
download | android-node-v8-1665a9330c0fa9f4a79c900e6250938ac8d7a9e5.tar.gz android-node-v8-1665a9330c0fa9f4a79c900e6250938ac8d7a9e5.tar.bz2 android-node-v8-1665a9330c0fa9f4a79c900e6250938ac8d7a9e5.zip |
stream: apply special logic in removeListener for readable.off()
We have special logic in removeListener() which must apply
to off() as well.
PR-URL: https://github.com/nodejs/node/pull/29486
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
-rw-r--r-- | lib/_stream_readable.js | 1 | ||||
-rw-r--r-- | test/parallel/test-stream-readable-readable-then-resume.js | 2 |
2 files changed, 3 insertions, 0 deletions
diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js index 2dc1323f09..eb7d5011d4 100644 --- a/lib/_stream_readable.js +++ b/lib/_stream_readable.js @@ -918,6 +918,7 @@ Readable.prototype.removeListener = function(ev, fn) { return res; }; +Readable.prototype.off = Readable.prototype.removeListener; Readable.prototype.removeAllListeners = function(ev) { const res = Stream.prototype.removeAllListeners.apply(this, arguments); diff --git a/test/parallel/test-stream-readable-readable-then-resume.js b/test/parallel/test-stream-readable-readable-then-resume.js index 83cf49333a..63dbc306e7 100644 --- a/test/parallel/test-stream-readable-readable-then-resume.js +++ b/test/parallel/test-stream-readable-readable-then-resume.js @@ -2,6 +2,7 @@ const common = require('../common'); const { Readable } = require('stream'); +const assert = require('assert'); // This test verifies that a stream could be resumed after // removing the readable event in the same tick @@ -24,6 +25,7 @@ function check(s) { const readableListener = common.mustNotCall(); s.on('readable', readableListener); s.on('end', common.mustCall()); + assert.strictEqual(s.removeListener, s.off); s.removeListener('readable', readableListener); s.resume(); } |