summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobin Neatherway <robin.neatherway@gmail.com>2019-01-30 12:55:54 -0500
committerRefael Ackermann <refack@gmail.com>2019-02-06 11:09:29 -0500
commit106dd1e345bcaa2f73ba7120a1163f8c6a021633 (patch)
treef041c5497af4305835b349d1a281b83fe2ca2f98
parent91adbe14b4490483785e1cd094c1130278cd25f3 (diff)
downloadandroid-node-v8-106dd1e345bcaa2f73ba7120a1163f8c6a021633.tar.gz
android-node-v8-106dd1e345bcaa2f73ba7120a1163f8c6a021633.tar.bz2
android-node-v8-106dd1e345bcaa2f73ba7120a1163f8c6a021633.zip
lib: fix a few minor issues flagged by lgtm
* Confusing (but correct) regex using `A-z` character range by accident * Add the status argument to afterShutdown PR-URL: https://github.com/nodejs/node/pull/25873 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
-rw-r--r--lib/internal/http2/core.js3
-rwxr-xr-xtools/cpplint.py2
2 files changed, 3 insertions, 2 deletions
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
index b78ecaf5ee..8e84eadbff 100644
--- a/lib/internal/http2/core.js
+++ b/lib/internal/http2/core.js
@@ -1515,7 +1515,8 @@ function streamOnPause() {
this[kHandle].readStop();
}
-function afterShutdown() {
+function afterShutdown(status) {
+ // Currently this status value is unused
this.callback();
const stream = this.handle[kOwner];
if (stream)
diff --git a/tools/cpplint.py b/tools/cpplint.py
index 17f341a61d..bae2707476 100755
--- a/tools/cpplint.py
+++ b/tools/cpplint.py
@@ -636,7 +636,7 @@ _NULL_TOKEN_PATTERN = re.compile(r'\bNULL\b')
_RIGHT_LEANING_POINTER_PATTERN = re.compile(r'[^=|(,\s><);&?:}]'
r'(?<!(sizeof|return))'
- r'\s\*[a-zA-z_][0-9a-zA-z_]*')
+ r'\s\*[a-zA-Z_][0-9a-zA-Z_]*')
_regexp_compile_cache = {}