summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2018-12-18 17:45:34 -0800
committerRich Trott <rtrott@gmail.com>2018-12-21 10:38:45 -0800
commit10642d625ef528c209f30bb10cd4c2ba4abfea8a (patch)
tree8f716b87c9e641600f8d2cedae31234a0b63c280
parentb0a334be8dc9e40845620785884bc0bbd596ee11 (diff)
downloadandroid-node-v8-10642d625ef528c209f30bb10cd4c2ba4abfea8a.tar.gz
android-node-v8-10642d625ef528c209f30bb10cd4c2ba4abfea8a.tar.bz2
android-node-v8-10642d625ef528c209f30bb10cd4c2ba4abfea8a.zip
tools: report unused disable-directives for ESLint
Refs: https://eslint.org/docs/user-guide/command-line-interface#--report-unused-disable-directives PR-URL: https://github.com/nodejs/node/pull/25119 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
-rw-r--r--Makefile2
-rw-r--r--vcbuild.bat2
2 files changed, 2 insertions, 2 deletions
diff --git a/Makefile b/Makefile
index 9f3f93c1e9..9dd9b19849 100644
--- a/Makefile
+++ b/Makefile
@@ -1159,7 +1159,7 @@ lint-md: | tools/.mdlintstamp
LINT_JS_TARGETS = .eslintrc.js benchmark doc lib test tools
run-lint-js = tools/node_modules/eslint/bin/eslint.js --cache \
- --ext=.js,.mjs,.md $(LINT_JS_TARGETS)
+ --report-unused-disable-directives --ext=.js,.mjs,.md $(LINT_JS_TARGETS)
run-lint-js-fix = $(run-lint-js) --fix
.PHONY: lint-js-fix
diff --git a/vcbuild.bat b/vcbuild.bat
index a63b2dfb33..215d0f4454 100644
--- a/vcbuild.bat
+++ b/vcbuild.bat
@@ -632,7 +632,7 @@ if defined lint_js_ci goto lint-js-ci
if not defined lint_js goto lint-md-build
if not exist tools\node_modules\eslint goto no-lint
echo running lint-js
-%config%\node tools\node_modules\eslint\bin\eslint.js --cache --rule "linebreak-style: 0" --ext=.js,.mjs,.md .eslintrc.js benchmark doc lib test tools
+%config%\node tools\node_modules\eslint\bin\eslint.js --cache --report-unused-disable-directives --rule "linebreak-style: 0" --ext=.js,.mjs,.md .eslintrc.js benchmark doc lib test tools
goto lint-md-build
:lint-js-ci