summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBen Noordhuis <info@bnoordhuis.nl>2016-06-28 21:21:21 +0200
committerBen Noordhuis <info@bnoordhuis.nl>2016-06-28 21:21:21 +0200
commit0ba0eca986b62fead7b79c694819c0b11672e7b0 (patch)
tree335e2a6d8f240d7f95987c1f8667056def2d7e4c
parent8e395222de010c65110988e72068fcf2b2f09030 (diff)
downloadandroid-node-v8-0ba0eca986b62fead7b79c694819c0b11672e7b0.tar.gz
android-node-v8-0ba0eca986b62fead7b79c694819c0b11672e7b0.tar.bz2
android-node-v8-0ba0eca986b62fead7b79c694819c0b11672e7b0.zip
src: fix readability/namespace cpplint warnings
PR-URL: https://github.com/nodejs/node/pull/7462 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
-rw-r--r--src/node_win32_etw_provider.cc3
-rw-r--r--src/spawn_sync.h3
-rw-r--r--src/string_search.cc5
-rw-r--r--src/string_search.h4
-rw-r--r--test/addons/make-callback-recurse/binding.cc2
-rw-r--r--test/addons/make-callback/binding.cc2
6 files changed, 11 insertions, 8 deletions
diff --git a/src/node_win32_etw_provider.cc b/src/node_win32_etw_provider.cc
index 6877f1977d..3aa8578db0 100644
--- a/src/node_win32_etw_provider.cc
+++ b/src/node_win32_etw_provider.cc
@@ -187,4 +187,5 @@ void shutdown_etw() {
advapi = nullptr;
}
}
-}
+
+} // namespace node
diff --git a/src/spawn_sync.h b/src/spawn_sync.h
index 9f53f0a22b..8ddba479f3 100644
--- a/src/spawn_sync.h
+++ b/src/spawn_sync.h
@@ -222,7 +222,8 @@ class SyncProcessRunner {
Environment* env_;
};
-}
+
+} // namespace node
#endif // defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
diff --git a/src/string_search.cc b/src/string_search.cc
index 530a0e5468..326fba7c4a 100644
--- a/src/string_search.cc
+++ b/src/string_search.cc
@@ -6,5 +6,6 @@ namespace stringsearch {
int StringSearchBase::kBadCharShiftTable[kUC16AlphabetSize];
int StringSearchBase::kGoodSuffixShiftTable[kBMMaxShift + 1];
int StringSearchBase::kSuffixTable[kBMMaxShift + 1];
-}
-} // namespace node::stringsearch
+
+} // namespace stringsearch
+} // namespace node
diff --git a/src/string_search.h b/src/string_search.h
index 7827fe153e..b4cc9d6ac9 100644
--- a/src/string_search.h
+++ b/src/string_search.h
@@ -623,8 +623,8 @@ size_t SearchString(Vector<const Char> subject,
StringSearch<Char> search(pattern);
return search.Search(subject, start_index);
}
-}
-} // namespace node::stringsearch
+} // namespace stringsearch
+} // namespace node
namespace node {
using node::stringsearch::Vector;
diff --git a/test/addons/make-callback-recurse/binding.cc b/test/addons/make-callback-recurse/binding.cc
index 1c575910ef..1195dbe2ff 100644
--- a/test/addons/make-callback-recurse/binding.cc
+++ b/test/addons/make-callback-recurse/binding.cc
@@ -26,6 +26,6 @@ void Initialize(Local<Object> target) {
NODE_SET_METHOD(target, "makeCallback", MakeCallback);
}
-} // namespace anonymous
+} // namespace
NODE_MODULE(binding, Initialize)
diff --git a/test/addons/make-callback/binding.cc b/test/addons/make-callback/binding.cc
index 3012a39ff7..a1adb997bb 100644
--- a/test/addons/make-callback/binding.cc
+++ b/test/addons/make-callback/binding.cc
@@ -35,6 +35,6 @@ void Initialize(v8::Local<v8::Object> target) {
NODE_SET_METHOD(target, "makeCallback", MakeCallback);
}
-} // namespace anonymous
+} // namespace
NODE_MODULE(binding, Initialize)