summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Bevenius <daniel.bevenius@gmail.com>2019-01-16 12:28:48 +0100
committerDaniel Bevenius <daniel.bevenius@gmail.com>2019-01-21 05:51:48 +0100
commit07e0c4eaa3e91fa92f63486c0d0a12cc1f330597 (patch)
tree29d0823c6edb6a1dce824df88ff0314f625c003a
parentaf102c6d277165a641a4082b0641388807985875 (diff)
downloadandroid-node-v8-07e0c4eaa3e91fa92f63486c0d0a12cc1f330597.tar.gz
android-node-v8-07e0c4eaa3e91fa92f63486c0d0a12cc1f330597.tar.bz2
android-node-v8-07e0c4eaa3e91fa92f63486c0d0a12cc1f330597.zip
test: change ciphers from RC4 to no-such-cipher
This commit updates option ciphers from 'RC4' to 'no-such-cipher' in test/parallel/test-tls-handshake-error.js. The motivation for this change is that this test is verifying that a 'no ciphers match' error be thrown, but 'RC4' might be among the ciphers supported by the OpenSSL version when dynamically linking. I ran into this specific issue when dynamically linking against OpenSSL 1.1.1 on RHEL8 using https://github.com/nodejs/node/pull/25381. PR-URL: https://github.com/nodejs/node/pull/25534 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
-rw-r--r--test/parallel/test-tls-handshake-error.js2
1 files changed, 1 insertions, 1 deletions
diff --git a/test/parallel/test-tls-handshake-error.js b/test/parallel/test-tls-handshake-error.js
index 2aef1adcc3..500e7a0cc6 100644
--- a/test/parallel/test-tls-handshake-error.js
+++ b/test/parallel/test-tls-handshake-error.js
@@ -19,7 +19,7 @@ const server = tls.createServer({
assert.throws(() => {
tls.connect({
port: this.address().port,
- ciphers: 'RC4'
+ ciphers: 'no-such-cipher'
}, common.mustNotCall());
}, /no cipher match/i);