diff options
author | Gibson Fahnestock <gib@uk.ibm.com> | 2017-01-17 10:30:43 +0000 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2017-01-22 19:11:42 -0800 |
commit | 067be658f966dafe3d16bdd7b5bbb7c5e58c7250 (patch) | |
tree | 0c434e44cbe25189e93c20163c814ac260f6e596 | |
parent | dcab88d529da07a73174ffb5e93cd3652a4fe0dd (diff) | |
download | android-node-v8-067be658f966dafe3d16bdd7b5bbb7c5e58c7250.tar.gz android-node-v8-067be658f966dafe3d16bdd7b5bbb7c5e58c7250.tar.bz2 android-node-v8-067be658f966dafe3d16bdd7b5bbb7c5e58c7250.zip |
test: don't connect to :: (use localhost instead)
If a test does http.listen(0) or net.listen(0),
http.listen(0).address().address returns '::'. Some machines will
resolve this to localhost, but not all. Every machine should have
localhost defined in /etc/hosts (or equivalent), so it should always
resolve.
Fixes: https://github.com/nodejs/node/issues/7291
PR-URL: https://github.com/nodejs/node/pull/10854
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
-rw-r--r-- | test/gc/test-net-timeout.js | 2 | ||||
-rw-r--r-- | test/parallel/test-http-status-reason-invalid-chars.js | 4 |
2 files changed, 2 insertions, 4 deletions
diff --git a/test/gc/test-net-timeout.js b/test/gc/test-net-timeout.js index c797bee41c..b8ea8e2089 100644 --- a/test/gc/test-net-timeout.js +++ b/test/gc/test-net-timeout.js @@ -35,7 +35,7 @@ function getall() { if (count >= todo) return; - const req = net.connect(server.address().port, server.address().address); + const req = net.connect(server.address().port); req.resume(); req.setTimeout(10, function() { req.destroy(); diff --git a/test/parallel/test-http-status-reason-invalid-chars.js b/test/parallel/test-http-status-reason-invalid-chars.js index 9950eeeee9..75ccb2c243 100644 --- a/test/parallel/test-http-status-reason-invalid-chars.js +++ b/test/parallel/test-http-status-reason-invalid-chars.js @@ -3,7 +3,6 @@ const common = require('../common'); const assert = require('assert'); const http = require('http'); -const net = require('net'); function explicit(req, res) { assert.throws(() => { @@ -34,8 +33,7 @@ const server = http.createServer((req, res) => { implicit(req, res); } }).listen(0, common.mustCall(() => { - const addr = server.address().address; - const hostname = net.isIPv6(addr) ? `[${addr}1]` : addr; + const hostname = 'localhost'; const url = `http://${hostname}:${server.address().port}`; let left = 2; const check = common.mustCall((res) => { |