buffer: special case empty string writes

Prior to 119354f we specifically handled passing a zero length string
to write on a buffer, restore that functionality.

2 files changed, 16 insertions, 1 deletions

diff --git a/src/node_buffer.cc b/src/node_buffer.cc
index 2dfddc7644..8153c8319a 100644
--- a/src/node_buffer.cc
+++ b/src/node_buffer.cc
@@ -345,7 +345,15 @@ Handle<Value> Buffer::StringWrite(const Arguments& args) {
 
   Local<String> str = args[0].As<String>();
 
-  if (encoding == HEX && str->Length() % 2 != 0)
+  int length = str->Length();
+
+  if (length == 0) {
+    constructor_template->GetFunction()->Set(chars_written_sym,
+                                             Integer::New(0));
+    return scope.Close(Integer::New(0));
+  }
+
+  if (encoding == HEX && length % 2 != 0)
     return ThrowTypeError("Invalid hex string");
 
   size_t offset = args[1]->Int32Value();
diff --git a/test/simple/test-buffer.js b/test/simple/test-buffer.js
index 0d071127c9..3026824f0a 100644
--- a/test/simple/test-buffer.js
+++ b/test/simple/test-buffer.js
@@ -998,3 +998,10 @@ assert.equal(Buffer.byteLength('aaaa==', 'base64'), 3);
 assert.throws(function() {
   Buffer('', 'buffer');
 }, TypeError);
+
+assert.doesNotThrow(function () {
+  var slow = new SlowBuffer(1);
+  assert(slow.write('', Buffer.poolSize * 10) === 0);
+  var fast = new Buffer(1);
+  assert(fast.write('', Buffer.poolSize * 10) === 0);
+});