diff options
| author | Christian Clauss <cclauss@me.com> | 2019-10-27 11:10:58 +0100 |
|---|---|---|
| committer | cclauss <cclauss@me.com> | 2019-10-31 21:54:34 +0100 |
| commit | b23b8dc0fab6153ce73019247aa8d0c306ad1fb0 (patch) | |
| tree | 1ab4e86bcbe8bbba46e6cdce206c656f48e7b15e /.travis.yml | |
| parent | 1f080fcb47c6febd0bd4519897d12df54dead1e3 (diff) | |
| download | android-node-v8-b23b8dc0fab6153ce73019247aa8d0c306ad1fb0.tar.gz android-node-v8-b23b8dc0fab6153ce73019247aa8d0c306ad1fb0.tar.bz2 android-node-v8-b23b8dc0fab6153ce73019247aa8d0c306ad1fb0.zip | |
build: find Python syntax errors in dependencies
As discussed in
https://github.com/nodejs/node/issues/30129#issuecomment-546662351, when
we vendor in code, we own the Syntax Errors in that code. This PR adds
The `.flake8` config file at the root of this repo puts blinders on the
linting of our dependencies so this test disables that file before
linting.
fixup: allow_failures until dependencies pass
PR-URL: https://github.com/nodejs/node/pull/30143
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Diffstat (limited to '.travis.yml')
| -rw-r--r-- | .travis.yml | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/.travis.yml b/.travis.yml index 8aa321ec16..6c16bdad82 100644 --- a/.travis.yml +++ b/.travis.yml @@ -88,3 +88,15 @@ jobs: - if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then bash -x tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST}; fi + + - name: "Find syntax errors in our Python dependencies" + language: python + python: 3.8 + install: + - mv .flake8 disabled.flake8 # take the blinders off of flake8 + - python3.8 -m pip install --upgrade pip + - python3.8 -m pip install flake8 + script: + - flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics + allow_failures: # TODO (cclauss): remove this when dependencies are clean + - name: "Find syntax errors in our Python dependencies" |