diff options
author | Anna Henningsen <anna@addaleax.net> | 2019-02-07 21:19:07 +0100 |
---|---|---|
committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-02-12 05:38:18 +0100 |
commit | 93417ac99521f0164dfacbbc0f7d30806d1ec0e3 (patch) | |
tree | d414e9ee589c518352f74c5dbf5cd1d46e8bcca5 /.mailmap | |
parent | 86799326077611d694f37753ee3ab6903397f893 (diff) | |
download | android-node-v8-93417ac99521f0164dfacbbc0f7d30806d1ec0e3.tar.gz android-node-v8-93417ac99521f0164dfacbbc0f7d30806d1ec0e3.tar.bz2 android-node-v8-93417ac99521f0164dfacbbc0f7d30806d1ec0e3.zip |
domain: avoid circular memory references
Avoid circular references that the JS engine cannot see through
because it involves an `async id` ⇒ `domain` link.
Using weak references is not a great solution, because it increases
the domain module’s dependency on internals and the added calls into
C++ may affect performance, but it seems like the least bad one.
PR-URL: https://github.com/nodejs/node/pull/25993
Fixes: https://github.com/nodejs/node/issues/23862
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to '.mailmap')
0 files changed, 0 insertions, 0 deletions