diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-04-04 11:36:41 +0800 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2019-04-06 12:04:36 +0800 |
| commit | de230555369087282213d337ecc1c315fbb74230 (patch) | |
| tree | 19e10179deff9ba47dac546af566e09a4a3f9a66 /.eslintrc.js | |
| parent | 864860e9f3d4eed0b0b81af55197d7e525ea6306 (diff) | |
| download | android-node-v8-de230555369087282213d337ecc1c315fbb74230.tar.gz android-node-v8-de230555369087282213d337ecc1c315fbb74230.tar.bz2 android-node-v8-de230555369087282213d337ecc1c315fbb74230.zip | |
lib: remove `env: node` in eslint config for lib files
This patch removes the redundant `require-globals` custom
eslint rule by removing `env: node` in the eslint config
and whitelist the globals that can be accessed in native
modules instead of black listing them. This makes sense
for our `lib/` files because here we are creating the
Node.js environment instead of running in a normal user
land Node.js environment.
PR-URL: https://github.com/nodejs/node/pull/27082
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to '.eslintrc.js')
| -rw-r--r-- | .eslintrc.js | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/.eslintrc.js b/.eslintrc.js index d3a6c73241..9aa90c6366 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -1,5 +1,7 @@ 'use strict'; +/* eslint-env node */ + const Module = require('module'); const path = require('path'); @@ -31,7 +33,6 @@ Module._findPath = (request, paths, isMain) => { module.exports = { root: true, plugins: ['markdown', 'node-core'], - env: { node: true, es6: true }, parser: 'babel-eslint', parserOptions: { sourceType: 'script' }, overrides: [ |