taler-typescript-core

commit e3595b049cf5b76e512c061e833ff39379d8f446
parent ee8640d166331140df9a2b075cf0de5413cdcb26
Author: Sebastian <sebasjm@gmail.com>
Date:   Tue,  1 Jul 2025 11:33:31 -0300

differences in the spec with libeufin current impl

Diffstat:
M
packages/taler-harness/src/integrationtests/test-withdrawal-conversion.ts
 | 
2
++
M
packages/taler-util/src/http-client/bank-core.ts
 | 
3
++-
M
packages/taler-util/src/types-taler-bank-conversion.ts
 | 
12
++++--------

3 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/packages/taler-harness/src/integrationtests/test-withdrawal-conversion.ts b/packages/taler-harness/src/integrationtests/test-withdrawal-conversion.ts
@@ -96,10 +96,12 @@ async function runTestfakeConversionService(): Promise<TestfakeConversionService
             cashin_min_amount: "A:0.1" as AmountString,
             cashin_ratio: "1",
             cashin_rounding_mode: "zero",
+            cashin_tiny_amount: "A:0.1" as AmountString,
             cashout_fee: "A:1" as AmountString,
             cashout_min_amount: "A:0.1" as AmountString,
             cashout_ratio: "1",
             cashout_rounding_mode: "zero",
+            cashout_tiny_amount: "A:0.1" as AmountString,
           },
         } satisfies TalerBankConversionApi.TalerConversionInfoConfig),
       );
diff --git a/packages/taler-util/src/http-client/bank-core.ts b/packages/taler-util/src/http-client/bank-core.ts
@@ -1148,13 +1148,14 @@ export class TalerCoreBankHttpClient {
    * https://docs.taler.net/core/api-corebank.html#patch--conversion-rate-classes-CLASS_ID
    *
    */
-  async updateConversionRateClass(auth: AccessToken, cid: number) {
+  async updateConversionRateClass(auth: AccessToken, cid: number, body: ConversionRateClassInput) {
     const url = new URL(`conversion-rate-classes/${cid}`, this.baseUrl);
     const resp = await this.httpLib.fetch(url.href, {
       method: "PATCH",
       headers: {
         Authorization: makeBearerTokenAuthHeader(auth),
       },
+      body,
     });
     switch (resp.status) {
       case HttpStatusCode.NoContent:
diff --git a/packages/taler-util/src/types-taler-bank-conversion.ts b/packages/taler-util/src/types-taler-bank-conversion.ts
@@ -130,8 +130,7 @@ export interface ConversionRate {
   cashin_rounding_mode: RoundingMode;
 
   // Smallest possible regional amount, converted amount is rounded to this amount
-  // FIXME spec: is this depreacted?
-  // cashin_tiny_amount: AmountString;
+  cashin_tiny_amount: AmountString;
 
   // Minimum amount authorised for cashout, in regional before conversion
   cashout_min_amount: AmountString;
@@ -146,8 +145,7 @@ export interface ConversionRate {
   cashout_rounding_mode: RoundingMode;
 
   // Smallest possible fiat amount, converted amount is rounded to this amount
-  // FIXME spec: is this depreacted?
-  // cashout_tiny_amount: AmountString;
+  cashout_tiny_amount: AmountString;
 }
 
 export const codecForCashoutConversionResponse =
@@ -177,8 +175,7 @@ export const codecForConversionRate = (): Codec<ConversionRate> =>
         codecForConstString("nearest"),
       ),
     )
-    // FIXME spec: depreacted?
-    // .property("cashin_tiny_amount", codecForAmountString())
+    .property("cashin_tiny_amount", codecForAmountString())
     .property("cashout_fee", codecForAmountString())
     .property("cashout_min_amount", codecForAmountString())
     .property("cashout_ratio", codecForDecimalNumber())
@@ -190,8 +187,7 @@ export const codecForConversionRate = (): Codec<ConversionRate> =>
         codecForConstString("nearest"),
       ),
     )
-    // FIXME spec: depreacted?
-    // .property("cashout_tiny_amount", codecForAmountString())
+    .property("cashout_tiny_amount", codecForAmountString())
     .build("ConversionBankConfig.ConversionInfo");
 
 export const codecForConversionBankConfig =