taler-typescript-core

commit ee8640d166331140df9a2b075cf0de5413cdcb26
parent cb90e3dbc432a31aadbef135d8adf51067c79204
Author: Sebastian <sebasjm@gmail.com>
Date:   Tue,  1 Jul 2025 07:27:31 -0300

fix API

Diffstat:
M
packages/taler-util/src/http-client/bank-core.ts
 | 
15
+++++++--------
M
packages/taler-util/src/types-taler-corebank.ts
 | 
8
++++----

2 files changed, 11 insertions(+), 12 deletions(-)
diff --git a/packages/taler-util/src/http-client/bank-core.ts b/packages/taler-util/src/http-client/bank-core.ts
@@ -585,20 +585,19 @@ export class TalerCoreBankHttpClient {
    * https://docs.taler.net/core/api-corebank.html#get--accounts
    *
    */
-  async getAccounts(
+  async listAccounts(
     auth: AccessToken,
-    filter: { account?: string; conversionRateId?: number } = {},
-    pagination?: PaginationParams,
+    params?: PaginationParams & { account?: string; conversionRateId?: number },
   ) {
     const url = new URL(`accounts`, this.baseUrl);
-    addPaginationParams(url, pagination);
-    if (filter.account !== undefined) {
-      url.searchParams.set("filter_name", filter.account);
+    addPaginationParams(url, params);
+    if (params?.account !== undefined) {
+      url.searchParams.set("filter_name", params.account);
     }
-    if (filter.conversionRateId !== undefined) {
+    if (params?.conversionRateId !== undefined) {
       url.searchParams.set(
         "conversion_rate_class_id",
-        String(filter.conversionRateId),
+        String(params.conversionRateId),
       );
     }
     const resp = await this.httpLib.fetch(url.href, {
diff --git a/packages/taler-util/src/types-taler-corebank.ts b/packages/taler-util/src/types-taler-corebank.ts
@@ -469,7 +469,7 @@ export interface ConversionRateClass {
   num_users: Integer;
 
   // Applied conversion rate
-  conversion_rate: ConversionRate;
+  conversion_rate?: ConversionRate;
 
   // Minimum fiat amount authorised for cashin before conversion
   cashin_min_amount?: AmountString;
@@ -979,13 +979,13 @@ export const codecForConversionRateClass = (): Codec<ConversionRateClass> =>
     .property("cashout_ratio", codecOptional(codecForDecimalNumber()))
     .property(
       "cashout_rounding_mode",
-      codecForEither(
+      codecOptional(codecForEither(
         codecForConstString("zero"),
         codecForConstString("up"),
         codecForConstString("nearest"),
-      ),
+      )),
     )
-    .property("conversion_rate", codecForConversionRate())
+    .property("conversion_rate", codecOptional(codecForConversionRate()))
     .property("conversion_rate_class_id", codecForNumber())
     .property("description", codecOptional(codecForString()))
     .property("name", codecForString())