-code cleanupv0.9.3-dev.1

1 files changed, 3 insertions, 15 deletions

diff --git a/src/backend/taler-merchant-httpd_post-tips-ID-pickup.c b/src/backend/taler-merchant-httpd_post-tips-ID-pickup.c
index da482cda..7cfc4beb 100644
--- a/src/backend/taler-merchant-httpd_post-tips-ID-pickup.c
+++ b/src/backend/taler-merchant-httpd_post-tips-ID-pickup.c
@@ -655,7 +655,7 @@ TMH_post_tips_ID_pickup (const struct TMH_RequestHandler *rh,
 
   if (NULL == pc)
   {
-    json_t *planchets;
+    const json_t *planchets;
     json_t *planchet;
     size_t index;
 
@@ -678,8 +678,8 @@ TMH_post_tips_ID_pickup (const struct TMH_RequestHandler *rh,
 
     {
       struct GNUNET_JSON_Specification spec[] = {
-        GNUNET_JSON_spec_json ("planchets",
-                               &planchets),
+        GNUNET_JSON_spec_array_const ("planchets",
+                                      &planchets),
         GNUNET_JSON_spec_end ()
       };
       {
@@ -694,16 +694,6 @@ TMH_post_tips_ID_pickup (const struct TMH_RequestHandler *rh,
                  : MHD_NO;
       }
     }
-    if (! json_is_array (planchets))
-    {
-      GNUNET_break_op (0);
-      json_decref (planchets);
-      return TALER_MHD_reply_with_error (connection,
-                                         MHD_HTTP_BAD_REQUEST,
-                                         TALER_EC_GENERIC_PARAMETER_MALFORMED,
-                                         "planchets");
-    }
-
     GNUNET_array_grow (pc->planchets,
                        pc->planchets_length,
                        json_array_size (planchets));
@@ -724,14 +714,12 @@ TMH_post_tips_ID_pickup (const struct TMH_RequestHandler *rh,
                                          spec);
         if (GNUNET_OK != res)
         {
-          json_decref (planchets);
           return (GNUNET_NO == res)
                  ? MHD_YES
                  : MHD_NO;
         }
       }
     }
-    json_decref (planchets);
     {
       struct GNUNET_HashContext *hc;