Respond 500 when bank rotates keys.

2 files changed, 12 insertions, 9 deletions

diff --git a/nexus/src/main/kotlin/tech/libeufin/nexus/ebics/EbicsClient.kt b/nexus/src/main/kotlin/tech/libeufin/nexus/ebics/EbicsClient.kt
index d3ab535a..65caf516 100644
--- a/nexus/src/main/kotlin/tech/libeufin/nexus/ebics/EbicsClient.kt
+++ b/nexus/src/main/kotlin/tech/libeufin/nexus/ebics/EbicsClient.kt
@@ -81,7 +81,6 @@ suspend fun doEbicsDownloadTransaction(
     val initDownloadRequestStr = createEbicsRequestForDownloadInitialization(subscriberDetails, orderType, orderParams)
     val payloadChunks = LinkedList<String>()
     val initResponseStr = client.postToBank(subscriberDetails.ebicsUrl, initDownloadRequestStr)
-
     val initResponse = parseAndValidateEbicsResponse(subscriberDetails, initResponseStr)
 
     when (initResponse.technicalReturnCode) {
diff --git a/nexus/src/main/kotlin/tech/libeufin/nexus/ebics/EbicsNexus.kt b/nexus/src/main/kotlin/tech/libeufin/nexus/ebics/EbicsNexus.kt
index 18f58489..2bbadbe1 100644
--- a/nexus/src/main/kotlin/tech/libeufin/nexus/ebics/EbicsNexus.kt
+++ b/nexus/src/main/kotlin/tech/libeufin/nexus/ebics/EbicsNexus.kt
@@ -391,7 +391,6 @@ fun formatHex(ba: ByteArray): String {
 }
 
 class EbicsBankConnectionProtocol: BankConnectionProtocol {
-
     override suspend fun fetchTransactions(
         fetchSpec: FetchSpecJson,
         client: HttpClient,
@@ -478,13 +477,18 @@ class EbicsBankConnectionProtocol: BankConnectionProtocol {
                 }
             }
         }
-        for (spec in specs) {
-            try {
-                fetchEbicsC5x(spec.orderType, client, bankConnectionId, spec.orderParams, subscriberDetails)
-            } catch (e: Exception) {
-                logger.warn("Ingestion failed for $spec")
-            }
-        }
+        /* Not handling errors here because
+          sub-calls should throw and get caught by
+          global handlers.
+         */
+        for (spec in specs)
+            fetchEbicsC5x(
+                spec.orderType,
+                client,
+                bankConnectionId,
+                spec.orderParams,
+                subscriberDetails
+            )
     }
 
     override suspend fun submitPaymentInitiation(httpClient: HttpClient, paymentInitiationId: Long) {