notes

2 files changed, 10 insertions, 8 deletions

diff --git a/database-versioning/new/sandbox-0001-refactor.sql b/database-versioning/new/sandbox-0001-refactor.sql
index ed846a00..65a1008b 100644
--- a/database-versioning/new/sandbox-0001-refactor.sql
+++ b/database-versioning/new/sandbox-0001-refactor.sql
@@ -1,4 +1,9 @@
--- Compatible with LibEuFin version: 1fe2687aaf696c8566367fe7ed082f1d78e6b78d
+
+-- Under discussion:
+
+-- amount format
+-- timestamp format
+-- comment format: '--' vs 'COMMENT ON'
 
 BEGIN;
 
@@ -6,18 +11,18 @@ SELECT _v.register_patch('sandbox-0001', NULL, NULL);
 
 CREATE TABLE IF NOT EXISTS demobankconfigs 
   (id BIGSERIAL PRIMARY KEY
-  ,hostname TEXT NOT NULL
+  ,name TEXT NOT NULL
   );
 
 CREATE TABLE IF NOT EXISTS bankaccounts 
   (id SERIAL PRIMARY KEY
   ,iban TEXT NOT NULL
-  ,bic TEXT DEFAULT 'SANDBOXX' NOT NULL
+  ,bic TEXT NOT NULL -- NOTE: This had a default of 'SANDBOXX', now Kotlin must keep it.
   ,"label" TEXT NOT NULL UNIQUE
   ,"owner" TEXT NOT NULL
   ,"isPublic" BOOLEAN DEFAULT false NOT NULL
   ,"demoBank" BIGINT REFERENCES demobankconfigs(id) ON DELETE RESTRICT ON UPDATE RESTRICT
-  ,"lastTransaction" BIGINT NULL REFERENCES bankaccounttransactions(id) ON DELETE RESTRICT ON UPDATE RESTRICT
+  ,"lastTransaction" BIGINT NULL REFERENCES bankaccounttransactions(id) ON DELETE RESTRICT ON UPDATE RESTRICT -- FIXME: under discussion on MM, might be removed.
   ,"lastFiatSubmission" BIGINT NULL REFERENCES bankaccounttransactions(id) ON DELETE RESTRICT ON UPDATE RESTRICT
   ,"lastFiatFetch" TEXT DEFAULT '0' NOT NULL
   ,"balance" TEXT DEFAULT '0'
diff --git a/sandbox/src/main/kotlin/tech/libeufin/sandbox/DB.kt b/sandbox/src/main/kotlin/tech/libeufin/sandbox/DB.kt
index 87db263e..934dbc4f 100644
--- a/sandbox/src/main/kotlin/tech/libeufin/sandbox/DB.kt
+++ b/sandbox/src/main/kotlin/tech/libeufin/sandbox/DB.kt
@@ -529,10 +529,7 @@ object BankAccountsTable : IntIdTable() {
     /**
      * Tracks the last fiat payment that was read from Nexus.  This tracker
      * gets updated ONLY IF the exchange gets successfully paid with the related
-     * amount in the regional currency.  NOTE: in case of disputes, the customer
-     * will provide the date of a problematic withdrawal, and the regional currency
-     * administrator should check into the "admin" (regional) outgoing history by
-     * using such date as filter.
+     * amount in the regional currency.
      */
     val lastFiatFetch = text("lastFiatFetch").default("0")
 }