diff options
author | Alba Mendez <me@alba.sh> | 2020-12-06 19:06:07 +0100 |
---|---|---|
committer | Alba Mendez <me@alba.sh> | 2020-12-12 23:59:58 +0100 |
commit | 78d1f8db5da26d3b635b07348f465561895121fe (patch) | |
tree | 6dfe6d1b195cdd8cbb3bddc83d5e1da3afbf2f63 /test | |
parent | 5a3c41133085a074b4e974b110276c0e450cf0c9 (diff) | |
download | ios-node-v8-78d1f8db5da26d3b635b07348f465561895121fe.tar.gz ios-node-v8-78d1f8db5da26d3b635b07348f465561895121fe.tar.bz2 ios-node-v8-78d1f8db5da26d3b635b07348f465561895121fe.zip |
tls: forward new SecureContext options
We have a few places where we individually forward each
parameter to tls.createSecureContext(). In #28973 and others,
we added new SecureContext options but forgot to keep these
places up to date.
As per https.Agent#getName, I understand that at least
`privateKeyIdentifier` and `privateKeyEngine` should be
added too, since they're a substitute for `key`. I've
also added sigalgs.
Fixes: https://github.com/nodejs/node/issues/36322
Refs: https://github.com/nodejs/node/pull/28973
PR-URL: https://github.com/nodejs/node/pull/36416
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-https-agent-getname.js | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/test/parallel/test-https-agent-getname.js b/test/parallel/test-https-agent-getname.js index dabb08f074..6f8c32b299 100644 --- a/test/parallel/test-https-agent-getname.js +++ b/test/parallel/test-https-agent-getname.js @@ -12,7 +12,7 @@ const agent = new https.Agent(); // empty options assert.strictEqual( agent.getName({}), - 'localhost:::::::::::::::::::' + 'localhost::::::::::::::::::::::' ); // Pass all options arguments @@ -34,11 +34,15 @@ const options = { secureOptions: 0, secureProtocol: 'secureProtocol', servername: 'localhost', - sessionIdContext: 'sessionIdContext' + sessionIdContext: 'sessionIdContext', + sigalgs: 'sigalgs', + privateKeyIdentifier: 'privateKeyIdentifier', + privateKeyEngine: 'privateKeyEngine', }; assert.strictEqual( agent.getName(options), '0.0.0.0:443:192.168.1.1:ca:cert:dynamic:ciphers:key:pfx:false:localhost:' + - '::secureProtocol:c,r,l:false:ecdhCurve:dhparam:0:sessionIdContext' + '::secureProtocol:c,r,l:false:ecdhCurve:dhparam:0:sessionIdContext:' + + '"sigalgs":privateKeyIdentifier:privateKeyEngine' ); |