diff options
author | Joyee Cheung <joyeec9h3@gmail.com> | 2020-07-21 08:56:47 +0800 |
---|---|---|
committer | gengjiawen <technicalcute@gmail.com> | 2020-07-22 13:37:12 +0000 |
commit | f4f191bbc26c367ed8fa56c2d1297ef437c5f0fb (patch) | |
tree | f97391dc092d69ea889aed55cc642d1728e49219 /node.gyp | |
parent | 07b3aae04e659d3681b9055164f4543c8c59b07a (diff) | |
download | ios-node-v8-f4f191bbc26c367ed8fa56c2d1297ef437c5f0fb.tar.gz ios-node-v8-f4f191bbc26c367ed8fa56c2d1297ef437c5f0fb.tar.bz2 ios-node-v8-f4f191bbc26c367ed8fa56c2d1297ef437c5f0fb.zip |
build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot
Otherwise the build would fail with
`./configure --experimental-quic --ninja` as the list of per-Environment
values would not match and the code cache builder would not generate
code cache for the quic JS sources. This is more or less a band-aid -
a proper fix would be to aggregate these flags into something
that can be included by all these different binary targets.
See https://github.com/nodejs/node/issues/31074.
PR-URL: https://github.com/nodejs/node/pull/34454
Fixes: https://github.com/nodejs/node/issues/34435
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Diffstat (limited to 'node.gyp')
-rw-r--r-- | node.gyp | 10 |
1 files changed, 10 insertions, 0 deletions
@@ -1376,6 +1376,11 @@ 'HAVE_OPENSSL=1', ], }], + [ 'node_use_openssl=="true" and experimental_quic==1', { + 'defines': [ + 'NODE_EXPERIMENTAL_QUIC=1', + ], + }], ['v8_enable_inspector==1', { 'defines': [ 'HAVE_INSPECTOR=1', @@ -1430,6 +1435,11 @@ 'HAVE_OPENSSL=1', ], }], + [ 'node_use_openssl=="true" and experimental_quic==1', { + 'defines': [ + 'NODE_EXPERIMENTAL_QUIC=1', + ], + }], ['v8_enable_inspector==1', { 'defines': [ 'HAVE_INSPECTOR=1', |