aboutsummaryrefslogtreecommitdiff
path: root/benchmark
diff options
context:
space:
mode:
authorDaniele Belardi <dwon.dnl@gmail.com>2020-02-14 14:59:09 +0100
committerAnna Henningsen <anna@addaleax.net>2020-03-30 10:16:24 +0200
commit75aaf7496e1ff6272b5d76372aecbf6f37fbc3d4 (patch)
treef7201670e5e7d6a25dac7b4a0c1c997119bead63 /benchmark
parent806899fdbaf5e8e1b71f8a8f0efd61ef131350f5 (diff)
downloadios-node-v8-75aaf7496e1ff6272b5d76372aecbf6f37fbc3d4.tar.gz
ios-node-v8-75aaf7496e1ff6272b5d76372aecbf6f37fbc3d4.tar.bz2
ios-node-v8-75aaf7496e1ff6272b5d76372aecbf6f37fbc3d4.zip
benchmark: use let instead of var in zlib
PR-URL: https://github.com/nodejs/node/pull/31794 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'benchmark')
-rw-r--r--benchmark/zlib/creation.js5
-rw-r--r--benchmark/zlib/deflate.js20
2 files changed, 14 insertions, 11 deletions
diff --git a/benchmark/zlib/creation.js b/benchmark/zlib/creation.js
index 30e6afe6b4..c2d063c20d 100644
--- a/benchmark/zlib/creation.js
+++ b/benchmark/zlib/creation.js
@@ -15,17 +15,16 @@ function main({ n, type, options }) {
const fn = zlib[`create${type}`];
if (typeof fn !== 'function')
throw new Error('Invalid zlib type');
- var i = 0;
if (options === 'true') {
const opts = {};
bench.start();
- for (; i < n; ++i)
+ for (let i = 0; i < n; ++i)
fn(opts);
bench.end(n);
} else {
bench.start();
- for (; i < n; ++i)
+ for (let i = 0; i < n; ++i)
fn();
bench.end(n);
}
diff --git a/benchmark/zlib/deflate.js b/benchmark/zlib/deflate.js
index 6d3bda90c6..5baedc924d 100644
--- a/benchmark/zlib/deflate.js
+++ b/benchmark/zlib/deflate.js
@@ -13,11 +13,11 @@ function main({ n, method, inputLen }) {
method = method || 'deflate';
const chunk = Buffer.alloc(inputLen, 'a');
- var i = 0;
switch (method) {
// Performs `n` writes for a single deflate stream
- case 'createDeflate':
- var deflater = zlib.createDeflate();
+ case 'createDeflate': {
+ let i = 0;
+ const deflater = zlib.createDeflate();
deflater.resume();
deflater.on('finish', () => {
bench.end(n);
@@ -30,9 +30,11 @@ function main({ n, method, inputLen }) {
deflater.write(chunk, next);
})();
break;
+ }
// Performs `n` single deflate operations
- case 'deflate':
- var deflate = zlib.deflate;
+ case 'deflate': {
+ let i = 0;
+ const deflate = zlib.deflate;
bench.start();
(function next(err, result) {
if (i++ === n)
@@ -40,14 +42,16 @@ function main({ n, method, inputLen }) {
deflate(chunk, next);
})();
break;
+ }
// Performs `n` single deflateSync operations
- case 'deflateSync':
- var deflateSync = zlib.deflateSync;
+ case 'deflateSync': {
+ const deflateSync = zlib.deflateSync;
bench.start();
- for (; i < n; ++i)
+ for (let i = 0; i < n; ++i)
deflateSync(chunk);
bench.end(n);
break;
+ }
default:
throw new Error('Unsupported deflate method');
}