diff options
| author | Chinmoy Chakraborty <chinmoy12c@gmail.com> | 2020-12-08 16:37:51 +0530 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2020-12-16 10:39:24 -0800 |
| commit | 4a6200e28947af3a7e1f65a332f3d391bc967a67 (patch) | |
| tree | 47977dacad8ff333c3255cf6e3db8cc66634b47b | |
| parent | b55807573874142cc262f479a8344018831f93d9 (diff) | |
| download | ios-node-v8-4a6200e28947af3a7e1f65a332f3d391bc967a67.tar.gz ios-node-v8-4a6200e28947af3a7e1f65a332f3d391bc967a67.tar.bz2 ios-node-v8-4a6200e28947af3a7e1f65a332f3d391bc967a67.zip | |
doc: add issue reference to github pr template
The PR template should include a Reference isssue (Fixes #issue_number)
so the PR can be tracked back to the issue easily.For a beginner trying
to read PRs to become comfortable with the codebase,it is really helpful
if one can directly reach the issue the PR fixes.
Fixes: https://github.com/nodejs/node/issues/36338
PR-URL: https://github.com/nodejs/node/pull/36440
Reviewed-By: James M Snell <jasnell@gmail.com>
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 4 | ||||
| -rw-r--r-- | doc/guides/contributing/pull-requests.md | 4 |
2 files changed, 8 insertions, 0 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 66efca5cd0..dd3a2964c8 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -7,6 +7,10 @@ Bug fixes and new features should include tests and possibly benchmarks. Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md --> +#### Related Issues + +Fixes: https://github.com/nodejs/node/issues/<issue_number> + ##### Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index c61ac5ff37..627ae2218a 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -281,6 +281,10 @@ Bug fixes and new features should include tests and possibly benchmarks. Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md --> +#### Related Issues + +Fixes: https://github.com/nodejs/node/issues/<issue_number> + #### Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> |