-annotate bugs

8 files changed, 16 insertions, 16 deletions

diff --git a/src/exchange/taler-exchange-httpd_batch-deposit.c b/src/exchange/taler-exchange-httpd_batch-deposit.c
index 154629ed2..3e24f6571 100644
--- a/src/exchange/taler-exchange-httpd_batch-deposit.c
+++ b/src/exchange/taler-exchange-httpd_batch-deposit.c
@@ -261,7 +261,7 @@ batch_deposit_transaction (void *cls,
                                  deposit,
                                  known_coin_id,
                                  &dc->h_payto,
-                                 false, /* FIXME-OEC: extension blocked */
+                                 false, /* FIXME-OEC: #7270 extension blocked */
                                  &dc->exchange_timestamp,
                                  &balance_ok,
                                  &in_conflict);
@@ -279,7 +279,7 @@ batch_deposit_transaction (void *cls,
     }
     if (in_conflict)
     {
-      /* FIXME: conficting contract != insufficient funds */
+      /* FIXME: #7267 conficting contract != insufficient funds */
       *mhd_ret
         = TEH_RESPONSE_reply_coin_insufficient_funds (
             connection,
@@ -496,7 +496,7 @@ parse_coin (struct MHD_Connection *connection,
   deposit->h_contract_terms = dc->h_contract_terms;
   deposit->wire_salt = dc->wire_salt;
   deposit->receiver_wire_account = (char *) dc->payto_uri;
-  /* FIXME-OEC: should NOT insert the extension details N times,
+  /* FIXME-OEC: #7270 should NOT insert the extension details N times,
      but rather insert them ONCE and then per-coin only use
      the resulting extension UUID/serial; so the data structure
      here should be changed once we look at extensions in earnest.  */
@@ -606,7 +606,7 @@ TEH_handler_batch_deposit (struct TEH_RequestContext *rc,
   TALER_merchant_wire_signature_hash (dc.payto_uri,
                                       &dc.wire_salt,
                                       &dc.h_wire);
-  /* FIXME-OEC: hash actual extension JSON object here */
+  /* FIXME-OEC: #7270 hash actual extension JSON object here */
   // if (! no_extensions)
   memset (&dc.h_extensions,
           0,
diff --git a/src/exchange/taler-exchange-httpd_csr.c b/src/exchange/taler-exchange-httpd_csr.c
index 1abe55639..14d82ef11 100644
--- a/src/exchange/taler-exchange-httpd_csr.c
+++ b/src/exchange/taler-exchange-httpd_csr.c
@@ -178,7 +178,7 @@ TEH_handler_csr_melt (struct TEH_RequestContext *rc,
         }
 
         /* derive r_pub */
-        // FIXME: bundle all requests into one derivation request (TEH_keys_..., crypto helper, security module)
+        // FIXME-#7272: bundle all requests into one derivation request (TEH_keys_..., crypto helper, security module)
         ec = TEH_keys_denomination_cs_r_pub_melt (denom_pub_hash,
                                                   nonce,
                                                   r_pub);
diff --git a/src/exchange/taler-exchange-httpd_db.c b/src/exchange/taler-exchange-httpd_db.c
index 6f0fc41c9..5660074ee 100644
--- a/src/exchange/taler-exchange-httpd_db.c
+++ b/src/exchange/taler-exchange-httpd_db.c
@@ -61,7 +61,7 @@ TEH_make_coin_known (const struct TALER_CoinPublicInfo *coin,
                                     NULL);
     return GNUNET_DB_STATUS_HARD_ERROR;
   case TALER_EXCHANGEDB_CKS_DENOM_CONFLICT:
-    /* FIXME: insufficient_funds != denom conflict! See issue 0007267, need new
+    /* FIXME: insufficient_funds != denom conflict! See issue #7267, need new
      * strategy for evidence gathering */
     *mhd_ret = TEH_RESPONSE_reply_coin_insufficient_funds (
       connection,
@@ -70,7 +70,7 @@ TEH_make_coin_known (const struct TALER_CoinPublicInfo *coin,
       &coin->coin_pub);
     return GNUNET_DB_STATUS_HARD_ERROR;
   case TALER_EXCHANGEDB_CKS_AGE_CONFLICT:
-    /* FIXME: insufficient_funds != Age conflict! See issue 0007267, need new
+    /* FIXME: insufficient_funds != Age conflict! See issue #7267, need new
      * strategy for evidence gathering */
     *mhd_ret = TEH_RESPONSE_reply_coin_insufficient_funds (
       connection,
diff --git a/src/exchange/taler-exchange-httpd_deposit.c b/src/exchange/taler-exchange-httpd_deposit.c
index 672e7b6ea..b74669399 100644
--- a/src/exchange/taler-exchange-httpd_deposit.c
+++ b/src/exchange/taler-exchange-httpd_deposit.c
@@ -167,7 +167,7 @@ deposit_transaction (void *cls,
                                dc->deposit,
                                dc->known_coin_id,
                                &dc->h_payto,
-                               false, /* FIXME-OEC: extension blocked */
+                               false, /* FIXME-OEC: extension blocked #7270 */
                                &dc->exchange_timestamp,
                                &balance_ok,
                                &in_conflict);
@@ -184,7 +184,7 @@ deposit_transaction (void *cls,
   }
   if (in_conflict)
   {
-    /* FIXME: conficting contract != insufficient funds */
+    /* FIXME #7267: conficting contract != insufficient funds */
     *mhd_ret
       = TEH_RESPONSE_reply_coin_insufficient_funds (
           connection,
diff --git a/src/exchange/taler-exchange-httpd_extensions.c b/src/exchange/taler-exchange-httpd_extensions.c
index 5a6137383..d6c26f6f4 100644
--- a/src/exchange/taler-exchange-httpd_extensions.c
+++ b/src/exchange/taler-exchange-httpd_extensions.c
@@ -162,7 +162,7 @@ TEH_extensions_init ()
     return GNUNET_SYSERR;
   }
 
-  /* FIXME: shall we load the extensions from the config right away?
+  /* FIXME #7270: shall we load the extensions from the config right away?
    * We do have to for now, as otherwise denominations with age restriction
    * will not have the age mask set right upon initial generation.
    */
diff --git a/src/exchange/taler-exchange-httpd_purses_merge.c b/src/exchange/taler-exchange-httpd_purses_merge.c
index 144571d22..4fbdadb7e 100644
--- a/src/exchange/taler-exchange-httpd_purses_merge.c
+++ b/src/exchange/taler-exchange-httpd_purses_merge.c
@@ -485,9 +485,9 @@ TEH_handler_purses_merge (
   }
   else
   {
-    char *method = GNUNET_strdup ("FIXME-WAD");
+    char *method = GNUNET_strdup ("FIXME-WAD #7271");
 
-    /* FIXME: lookup wire method by pcc.provider_url! */
+    /* FIXME-#7271: lookup wire method by pcc.provider_url! */
     pcc.wf = TEH_wire_fees_by_time (pcc.exchange_timestamp,
                                     method);
     if (NULL == pcc.wf)
@@ -553,7 +553,7 @@ TEH_handler_purses_merge (
 
   if (GNUNET_TIME_absolute_is_past (pcc.purse_expiration.abs_time))
   {
-    // FIXME: idempotency check, otherwise generate 410!
+    // FIXME-BUG: idempotency check, otherwise generate 410!
   }
 
   /* execute transaction */
diff --git a/src/exchange/taler-exchange-httpd_refreshes_reveal.c b/src/exchange/taler-exchange-httpd_refreshes_reveal.c
index a0fd83bfa..a25d6ff43 100644
--- a/src/exchange/taler-exchange-httpd_refreshes_reveal.c
+++ b/src/exchange/taler-exchange-httpd_refreshes_reveal.c
@@ -751,7 +751,7 @@ clean_age:
   {
     enum TALER_ErrorCode ec;
 
-    // FIXME: replace with a batch call that
+    // FIXME #7272: replace with a batch call that
     // passes all coins in once go!
     ec = TEH_keys_denomination_sign_melt (
       &rrcs[i].h_denom_pub,
diff --git a/src/exchange/taler-exchange-router.c b/src/exchange/taler-exchange-router.c
index 0816dfdba..a1a247194 100644
--- a/src/exchange/taler-exchange-router.c
+++ b/src/exchange/taler-exchange-router.c
@@ -32,7 +32,7 @@
 #include "taler_bank_service.h"
 
 
-// FIXME: revisit how (and if) we do sharding!
+// FIXME #7271: revisit how (and if) we do sharding!
 // Maybe use different helpers for wads than
 // for local purses?!
 /**
@@ -282,7 +282,7 @@ run_routing (void *cls)
   task = NULL;
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
               "Checking for ready P2P transfers to route\n");
-  // FIXME: do actual work here!
+  // FIXME #7271: do actual work here!
   commit_or_warn ();
   release_shard (s);
   task = GNUNET_SCHEDULER_add_now (&run_shard,