diff options
author | Christian Grothoff <christian@grothoff.org> | 2024-04-23 19:32:10 +0200 |
---|---|---|
committer | Christian Grothoff <christian@grothoff.org> | 2024-04-23 19:32:10 +0200 |
commit | 07daf9f58ed29b8b4fff68db83f50c65f3142088 (patch) | |
tree | 87f150a1a59234b3e62dfffd8bd24a3a0b0c0f54 | |
parent | edf57eef91cb1ef1830dd90beda70357b18e9848 (diff) | |
download | docs-07daf9f58ed29b8b4fff68db83f50c65f3142088.tar.gz docs-07daf9f58ed29b8b4fff68db83f50c65f3142088.tar.bz2 docs-07daf9f58ed29b8b4fff68db83f50c65f3142088.zip |
thoughts for C2EC discussion tomorrow
-rw-r--r-- | core/api-bank-integration.rst | 12 | ||||
-rw-r--r-- | core/api-corebank.rst | 25 |
2 files changed, 31 insertions, 6 deletions
diff --git a/core/api-bank-integration.rst b/core/api-bank-integration.rst index 1d0f9db9..caf706a7 100644 --- a/core/api-bank-integration.rst +++ b/core/api-bank-integration.rst @@ -118,6 +118,12 @@ for the withdrawal operation (the ``WITHDRAWAL_ID``) to interact with the withdr // Optional since **vC2EC**. suggested_amount?: Amount; + // The non-Taler card fees the customer will have + // to pay to the bank / payment service provider + // they are using to make the withdrawal. + // @since **vC2EC** + card_fees?: Amount; + // Bank account of the customer that is debiting, as an // RFC 8905 ``payto`` URI. sender_wire?: string; @@ -260,7 +266,7 @@ for the withdrawal operation (the ``WITHDRAWAL_ID``) to interact with the withdr After all, a wallet could just do the same POST and then we'd store/process completely bogus information! - FIXME: why not use /accounts/$USERNAME/withdrawals/$WITHDRAWAL_ID/confirm? + FIXME: why not use /accounts/$USERNAME/withdrawals/$WITHDRAWAL_ID/confirm (and/or /accounts/$USERNAME/withdrawals?) instead? **Request:** @@ -284,6 +290,9 @@ for the withdrawal operation (the ``WITHDRAWAL_ID``) to interact with the withdr // The provider specific transaction identifier. // This identifier is used by the bank to attest the // payment at the providers backend. + // + // FIXME: how is this used? + // FIXME: what if it is wrong? provider_transaction_id: string; // An identifier, which identifies the device @@ -296,6 +305,7 @@ for the withdrawal operation (the ``WITHDRAWAL_ID``) to interact with the withdr // the exchange and be somehow registered. // // FIXME: probably more general to use a *string*. + // FIXME: how is this used? terminal_id: number; // The amount to withdraw. Fees are to be sent in the diff --git a/core/api-corebank.rst b/core/api-corebank.rst index 878542d3..80424464 100644 --- a/core/api-corebank.rst +++ b/core/api-corebank.rst @@ -708,19 +708,34 @@ Account withdrawals interface BankAccountCreateWithdrawalRequest { - // Amount to withdraw. - // FIXME: **vC2EC**: make this optional? - // FIXME: **vC2EC**: allow making merely a suggestion? - amount: Amount; + // Amount to withdraw. If given, the wallet + // cannot change the amount. + // Optional since **vC2EC**. + amount?: Amount; + + // Suggested amount to withdraw. The wallet can + // still change the suggestion. + // @since **vC2EC** + suggested_amount?: Amount; // KYC data in case where enable somebody else // to withdraw from "our" account? // FIXME: what would be a good ID? // FIXME: need a way to determine // and return limits per ID! - // @since **vC2EC**? + // FIXME: for C2EC we only learn the card at the + // *end* of the process, while with NDA we learn + // a user ID at the *beginning* of the process. + // How to handle both cases nicely? + // @since **vC2EC** kyc_link?: TBD; + // The non-Taler card fees the customer will have + // to pay to the account owner, bank and/or + // payment service provider + // they are using to make this withdrawal. + // @since **vC2EC** + card_fees?: Amount; } .. ts:def:: BankAccountCreateWithdrawalResponse |